After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649269 - gtkdoc-scanobj should set some of its own CFLAGS/LDFLAGS
gtkdoc-scanobj should set some of its own CFLAGS/LDFLAGS
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.15
Other Linux
: Normal blocker
: 1.18
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-03 11:54 UTC by Dan Winship
Modified: 2011-09-08 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Winship 2011-05-03 11:54:50 UTC
bug 648948 is about libsoup's gtk-doc scanning failing on debian because of gold's extra pickiness about not pulling in indirect dependencies automatically.

In order to make it work, he had to add $(GLIB_LIBS) to $(GTKDOC_LIBS) (because the foo-scan.c file that gtk-doc generates makes use of various glib/gobject symbols internally). But that seems like something gtk-doc should take care of itself; gtk-doc is the one using glib symbols, not me, so I shouldn't be the one specifying $(GLIB_LIBS); GTK_DOC_CHECK() should figure this out itself.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-05-10 12:37:45 UTC
Agree. I can't just assume $(GLIB_LIBS) though.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2011-05-10 13:30:32 UTC
Please reopen if thats not enough.

commit a81a174617241a0afcbb858896d9218297ad07bc
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Tue May 10 16:26:52 2011 +0300

    scanner: check for glib build flags in gtk-doc.m4
    
    We need to add the CFLAGS/LDFLAGS for glib ourself when building the scanner.
    Fixes #649269.
Comment 3 Allison Karlitskaya (desrt) 2011-07-11 10:11:15 UTC
This is a problem for GLib itself.

Doing a gtk-doc-enabled build of GLib from a tarball built with the new gtk-doc will now fail due to inability to find the glib-devel dependencies already installed on the system.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2011-08-31 12:26:50 UTC
Ryan, I could just make PKG_CHECK_MODULES non fatal. Then $(GTKDOC_DEPS_CFLAGS) and $(GTKDOC_DEPS_LIBS) is empty and thats what we had there before.

PKG_CHECK_MODULES(GTKDOC_DEPS, glib-2.0 >= 2.10.0 gobject-2.0  >= 2.10.0,,)

Its probably also better as in therory someone could use gtk-doc for a plain non glib library.
Comment 5 Allison Karlitskaya (desrt) 2011-09-01 03:35:19 UTC
If we do that and the dependencies *are* installed then wouldn't this result in them being used?  That's probably bad, since we don't want to scan the system GLib/GObject...
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2011-09-08 16:37:20 UTC
okay, that should fix it. Please reopen otherwise.

commit db374e766d85cc15c084542d0aae6c9df73c8737
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Thu Sep 8 18:32:35 2011 +0200

    gtk-doc.m4: only get glib_deps if we're not building glib and make it nonfatal
    
    If we're builing glib, we want uninstalled glib. If we're building docs for a
    non glib library we won't run scanobj.