After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648948 - make distcheck fails
make distcheck fails
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-04-29 14:52 UTC by arno
Modified: 2011-05-16 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
seems to fix build (680 bytes, patch)
2011-04-29 20:30 UTC, arno
none Details | Review

Description arno 2011-04-29 14:52:41 UTC
Hi,
on my system, make distcheck fails with following error:
libtool: link: gcc -g -O2 -Wall -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wdeclaration-after-statement -Wformat=2 -Winit-self -Waggregate-return -Wmissing-format-attribute -Wmissing-include-dirs -Wundef .libs/libsoup-2.4-scan.o -o .libs/libsoup-2.4-scan  ../../libsoup/.libs/libsoup-gnome-2.4.so -pthread
/usr/bin/ld.bfd.real: .libs/libsoup-2.4-scan.o: undefined reference to symbol 'soup_server_get_type'
/usr/bin/ld.bfd.real: .libs/libsoup-2.4-scan.o: undefined reference to symbol 'soup_server_get_type'
/usr/bin/ld.bfd.real: note: 'soup_server_get_type' is defined in DSO /tmp/libsoup/libsoup/.libs/libsoup-2.4.so.1 so try adding it to the linker command line
/tmp/libsoup/libsoup/.libs/libsoup-2.4.so.1: could not read symbols: Invalid operation

to reproduce:
$ git clone git://git.gnome.org/libsoup
$ cd libsoup/
$ ./autogen.sh&& make
$ make distcheck
Comment 1 arno 2011-04-29 20:30:08 UTC
Created attachment 186905 [details] [review]
seems to fix build

Actually, this happens when building the docs/reference directory. This can be reproduced by building a tree configured with --enable-gtk-doc
For some reason, this is fixed on my system with this patch.
Comment 2 Dan Winship 2011-05-02 21:12:00 UTC
Comment on attachment 186905 [details] [review]
seems to fix build

>+GTKDOC_LIBS = $(top_builddir)/libsoup/libsoup-gnome-2.4.la \
>+			  $(top_builddir)/libsoup/libsoup-2.4.la \
>+			  $(GLIB_LIBS)

Do you actually need GLIB_LIBS? What error does it give without that?
Comment 3 arno 2011-05-03 05:39:06 UTC
(In reply to comment #2)
> (From update of attachment 186905 [details] [review])
> >+GTKDOC_LIBS = $(top_builddir)/libsoup/libsoup-gnome-2.4.la \
> >+			  $(top_builddir)/libsoup/libsoup-2.4.la \
> >+			  $(GLIB_LIBS)
> 
> Do you actually need GLIB_LIBS? What error does it give without that?

Without GLIB_LIBS, compilation fails with

gtk-doc: Linking scanner
libtool: link: gcc -g -O2 -Wall -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wdeclaration-after-statement -Wformat=2 -Winit-self -Waggregate-return -Wmissing-format-attribute -Wmissing-include-dirs -Wundef .libs/libsoup-2.4-scan.o -o .libs/libsoup-2.4-scan  ../../libsoup/.libs/libsoup-gnome-2.4.so ../../libsoup/.libs/libsoup-2.4.so -pthread
/usr/bin/ld.bfd.real: .libs/libsoup-2.4-scan.o: undefined reference to symbol 'g_flags_get_first_value'
/usr/bin/ld.bfd.real: note: 'g_flags_get_first_value' is defined in DSO /usr/lib64/libgobject-2.0.so.0 so try adding it to the linker command line
/usr/lib64/libgobject-2.0.so.0: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
Linking of scanner failed:
Comment 4 Dan Winship 2011-05-03 12:05:41 UTC
OK, IMHO gtk-doc should be including $(GLIB_LIBS) itself, but, since
right now it doesn't, we can add it to libsoup. I filed bug 649269
about changing gtk-doc

fixed in master. thanks for the patch
Comment 5 Dan Winship 2011-05-16 08:35:59 UTC
forgot to close