GNOME Bugzilla – Bug 648922
Inconsistent avatar behavior.
Last modified: 2011-06-21 14:50:47 UTC
Created attachment 186854 [details] Step number 3 When I log in, empathy loads avatars for all the contacts that are online (and have pictures assigned by them). When a contact that was online and had its avatar loaded goes offline there is still picture available in the contact list. It looks weird and inconsistent when some of the offline contacts have avatars only because they were online and some don't. When empathy is turned off and then turned on situation happens again (though the avatars of contacts that were offline disappear). Steps to reproduce: 1) Log in to empathy 2) Enable show contacts when they're offline 3) Wait for a contact that has an avatar (for instance from a facebook account) to become online. 4) Wait for this contact to become offline <- this is when we have the offline contact with an avatar. 5) Turn the empathy off and on <- this is when contact loses its avatar. Possible solution would be storing avatar and loading it from the hard drive (even for offline contacts, maybe even for meta-contacts), or showing avatars only for online contacts
Created attachment 186855 [details] Step number 4
Created attachment 186856 [details] Step number 5 Added pictures showing the bug.
<cassidy> wjt, does Gabble give us avatars for offline contacts ? https://bugzilla.gnome.org/show_bug.cgi?id=648922 <xclaesse> cassidy, yes and no <xclaesse> cassidy, xmpp does not push token to us for offline contacts <xclaesse> cassidy, because the token is part of presence <xclaesse> cassidy, but you can force the fetch of vcard <cassidy> I see <cassidy> I guess we don't want to pull the vCard of all the offline contacts <xclaesse> exactly <xclaesse> because that makes cache useless <cassidy> yep, so that's the best we can do atm regarding what the protocol gives us <cassidy> thanks <xclaesse> cassidy, in fremantle we force the fetch the first time we see the contact <xclaesse> and the avatar is remembered <xclaesse> folks should do that <cassidy> humm yeah I was pondering that <cassidy> but afaik folks doesn't do any avatar storage atm <cassidy> treitter, ^ <xclaesse> you need to keep on disk a map (account path, contact id) -> token <cassidy> I guess that could make sense in folks yeah <xclaesse> and do a RequestAvatar call if the map is missing I guess this is kinda blocked by bug #627401 ?
I'm not sure if it is blocked, because it's not about how to get avatars, but about what to do with them. It just looks weird when offline contacts have avatars (that were grabbed when contact was online) and after exiting empathy and running it again they disappear. I hope you know what I mean.
This should be fixed by bug #652643. (Then offline contacts will still show their last-seen avatar). *** This bug has been marked as a duplicate of bug 652643 ***