After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648397 - gnome-shell: 12-hour string translated as a 24-hour string
gnome-shell: 12-hour string translated as a 24-hour string
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: Spanish [es]
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-es-list@gnome.org
gnome-es-list@gnome.org
Depends on: 648394
Blocks:
 
 
Reported: 2011-04-21 17:25 UTC by Owen Taylor
Modified: 2012-02-28 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Owen Taylor 2011-04-21 17:25:30 UTC
Below reported problem also applies to Spanish translation (search for %l to find all relevant strings)

+++ This bug was initially created as a clone of Bug #648394 +++

The formats string in gnome-shell.po that are supposed to be a 12-hour time format:

#. Translators: This is a time format with date used
#. for AM/PM.
#: ../js/ui/dateMenu.js:177
msgid "%a %b %e, %l:%M:%S %p"
msgstr "%a, %e. %b, %H:%M:%S"

#: ../js/ui/dateMenu.js:178
msgid "%a %b %e, %l:%M %p"
msgstr "%a, %e. %b, %H:%M"

#. Translators: This is a time format without date used
#. for AM/PM.
#: ../js/ui/dateMenu.js:182
msgid "%a %l:%M:%S %p"
msgstr "%a %H:%M:%S"

#: ../js/ui/dateMenu.js:183
msgid "%a %l:%M %p"
msgstr "%a %H:%M"

Are done as straight-up 24-hour time formats. This makes the switch in System Settings that is supposed to switch between 12-hour and 24-hour time do nothing, which looks buggy. 

 https://bugzilla.redhat.com/show_bug.cgi?id=698698

Compare the gnome-panel translation:

#: ../applets/clock/calendar-window.c:316 ../applets/clock/clock.c:448
#: ../applets/clock/clock-location-tile.c:507
msgid "%l:%M %p"
msgstr "%I:%M %p"

Since the default value for the toggle switch is a 24-hour format (for all locales), I don't think it matters that 12-hour time with AM/PM isn't natural in German.
Comment 1 Daniel Mustieles 2012-02-21 12:44:34 UTC
Is this bug still valid for master branch?
Comment 2 Owen Taylor 2012-02-28 16:59:45 UTC
No, it was eventually fixed by the commit:

commit f279b6bf7ea4b749d50d4ba7e9751b10e85eadbd
Author: Diego Escalante Urrelo <descalante@igalia.com>
Date:   Thu Aug 4 12:48:10 2011 +0200

    Update Spanish translation
    
    Forgotten "%p" in 12h time formats.
Comment 3 Daniel Mustieles 2012-02-28 17:03:07 UTC
Thanks :)