After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648394 - gnome-shell: 12-hour string translated as a 24-hour string
gnome-shell: 12-hour string translated as a 24-hour string
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: German [de]
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-de
gnome-de
Depends on:
Blocks: 648397 648398 648399 648400 648401 648402 648403 648404
 
 
Reported: 2011-04-21 17:17 UTC by Owen Taylor
Modified: 2011-04-22 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Owen Taylor 2011-04-21 17:17:22 UTC
The formats string in gnome-shell.po that are supposed to be a 12-hour time format:

#. Translators: This is a time format with date used
#. for AM/PM.
#: ../js/ui/dateMenu.js:177
msgid "%a %b %e, %l:%M:%S %p"
msgstr "%a, %e. %b, %H:%M:%S"

#: ../js/ui/dateMenu.js:178
msgid "%a %b %e, %l:%M %p"
msgstr "%a, %e. %b, %H:%M"

#. Translators: This is a time format without date used
#. for AM/PM.
#: ../js/ui/dateMenu.js:182
msgid "%a %l:%M:%S %p"
msgstr "%a %H:%M:%S"

#: ../js/ui/dateMenu.js:183
msgid "%a %l:%M %p"
msgstr "%a %H:%M"

Are done as straight-up 24-hour time formats. This makes the switch in System Settings that is supposed to switch between 12-hour and 24-hour time do nothing, which looks buggy. 

 https://bugzilla.redhat.com/show_bug.cgi?id=698698

Compare the gnome-panel translation:

#: ../applets/clock/calendar-window.c:316 ../applets/clock/clock.c:448
#: ../applets/clock/clock-location-tile.c:507
msgid "%l:%M %p"
msgstr "%I:%M %p"

Since the default value for the toggle switch is a 24-hour format (for all locales), I don't think it matters that 12-hour time with AM/PM isn't natural in German.
Comment 1 Owen Taylor 2011-04-21 22:23:06 UTC
I filed bug 648428 to improve translator comments.

See https://bugzilla.gnome.org/show_bug.cgi?id=648403#c2 for some clarifications about what should happen if %p is empty in a locale. (%p is apparently empty for sv and "AM/PM" for de, haven't checked more broadly.)
Comment 2 Hendrik Richter 2011-04-22 12:25:59 UTC
Thanks, I've fixed this with
   9c654a6..c28d35a  master -> master

I've changed the 12h time format to actually be 12h without am/pm, and also changed the calendar to always display 24h times. I hops this is okay now?

Owen, can you please add appropriate translator comments? Thanks!