After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646547 - typo in src/orca/orca_gui_prefs.py
typo in src/orca/orca_gui_prefs.py
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.91.x
Other All
: Normal trivial
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-02 17:53 UTC by Christian Kirbach
Modified: 2011-04-04 22:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch against master (684 bytes, patch)
2011-04-02 17:53 UTC, Christian Kirbach 		committed Details | Review
Also update the 3.0 branch .po files (15.20 KB, patch)
2011-04-04 21:08 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Christian Kirbach 2011-04-02 17:53:24 UTC 
-                    "have just make changes in your preferences, it will\n" \
+                    "have just made changes in your preferences, it will\n" \

in both 3-0 and master branches
Comment 1 Christian Kirbach 2011-04-02 17:53:41 UTC 
Created attachment 184958 [details] [review]
patch against master
Comment 2 Joanmarie Diggs (IRC: joanie) 2011-04-02 18:22:54 UTC 
Review of attachment 184958 [details] [review]:

Ugh. I positively hate when I don't catch those. :-(

Now that I'm looking at it. The 'it' appears to refer to the 'changes' (plural) which shall be dropped. Thus really, there are two typos; not one. Mind turning the 'it' into 'they' as well? If not, please commit the revised patch -- and then please paste a link to the commit (from git.gnome.org/browse/orca) as a comment so that we have the final version in this bug. Then I'll seek string freeze break for branch.

Thanks!
Comment 3 Christian Kirbach 2011-04-03 14:26:59 UTC 
Hi

revised as you suggested - this is actually how I translated it.
Commited to master.

http://git.gnome.org/browse/orca/commit/?id=8b10ef00104e906b8eccc2b38539d1018d932980


commit 8b10ef00104e906b8eccc2b38539d1018d932980
Author: Christian Kirbach <Christian.Kirbach@googlemail.com>
Date:   Sun Apr 3 16:24:12 2011 +0200

    Fix two typos in prefs string (bug #646547)
Comment 4 Joanmarie Diggs (IRC: joanie) 2011-04-04 21:08:32 UTC 
Created attachment 185150 [details] [review]
Also update the 3.0 branch .po files

2 members of the release team have specified that I must also "fix all .po files at the same time, to not break translations." Totally agreed. And I *believe* this patch does so based on what the wonderful folks in #i18n told me.
Comment 5 Joanmarie Diggs (IRC: joanie) 2011-04-04 22:18:04 UTC 
(In reply to comment #3)
> Hi
> 
> revised as you suggested - this is actually how I translated it.
> Commited to master.
> 
> http://git.gnome.org/browse/orca/commit/?id=8b10ef00104e906b8eccc2b38539d1018d932980
> 
> 
> commit 8b10ef00104e906b8eccc2b38539d1018d932980
> Author: Christian Kirbach <Christian.Kirbach@googlemail.com>
> Date:   Sun Apr 3 16:24:12 2011 +0200
> 
>     Fix two typos in prefs string (bug #646547)

Super thanks!!

I've also just pushed it into the gnome-3-0 branch:

http://git.gnome.org/browse/orca/commit/?h=gnome-3-0&id=29bfbfd27d1b4bf3a3bb13199fd79dfbbf7ab678

Along with the changes to the .po files specified by the RT:

http://git.gnome.org/browse/orca/commit/?id=1cbed0744cb844ad5ca255ebbf80a67575af65da