GNOME Bugzilla – Bug 646245
Fix the Jamendo plugin for GTK+ GIR breaks
Last modified: 2011-03-30 19:33:17 UTC
As it stands, the Jamendo plugin is fairly broken due to changes in GTK+'s GIR since the plugin was last given some love. Patches coming up to fix it.
Created attachment 184710 [details] [review] jamendo: Fix encoding problems with non-ASCII track names Fix some encoding problems when dealing with non-ASCII tracks in the Jamendo plugin.
Created attachment 184711 [details] [review] jamendo: Fix various tree model/view problems due to changes in GTK+'s GIR Fix breakage which was rendering the plugin mostly useless.
(Code freeze break requested for these patches and those in bug #646231.)
Comment on attachment 184710 [details] [review] jamendo: Fix encoding problems with non-ASCII track names commit 87cdefd461dfe8d3bfa4055f78bdb514c31ccf09 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Wed Mar 30 17:15:16 2011 +0100 jamendo: Fix encoding problems with non-ASCII track names Ensure that track names are uniformly decoded as UTF-8, and never re-encoded as ASCII. Attempting to re-encode them as ASCII was causing non-ASCII track names to (obviously) blow things up. Helps: bgo#646245 src/plugins/jamendo/jamendo.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Comment on attachment 184711 [details] [review] jamendo: Fix various tree model/view problems due to changes in GTK+'s GIR commit 8a3ccd91d3e1d791ec78386fb898cf4ddabe2246 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Wed Mar 30 17:16:27 2011 +0100 jamendo: Fix various tree model/view problems due to changes in GTK+'s GIR This fixes clicking, double-clicking and right-clicking on albums and tracks, meaning the plugin is actually useful. Closes: bgo#646245 src/plugins/jamendo/jamendo.py | 19 ++++++++++--------- 1 files changed, 10 insertions(+), 9 deletions(-)