GNOME Bugzilla – Bug 646231
Subtitle downloader plugin broken on 2.91.93
Last modified: 2011-03-30 19:34:17 UTC
Using totem 2.91.93 from F15 i get this msgs in stdout: totem Traceback (most recent call last):
+ Trace 226507
self.os_build_dialog(action)
combobox.set_active_iter(parentit)
return info.invoke(*args)
Pressing cancel or search for subtitles doesn't work.
Created attachment 184699 [details] [review] Fix opening the OpenSubtitles dialogue This was caused by a break in the GTK+ GIR file which we hadn't caught up with. There are another two patches coming to fix crashes/critical failures in the opensubtitles plugin, then I'll request a code freeze break.
Created attachment 184700 [details] [review] Fix the GDK key constants used in the OpenSubtitles plugin This fixes a Python error encountered if one presses a key while the OpenSubtitles dialogue is focussed (and fixes closing the dialogue by pressing the escape key).
Created attachment 184701 [details] [review] Fix parsing the subtitle file's URI in the OpenSubtitles plugin Third and final patch. This one fixes parsing the subtitle file's URI (it's a URI not a path), which actually allows subtitles to be downloaded and loaded correctly.
Comment on attachment 184699 [details] [review] Fix opening the OpenSubtitles dialogue commit faa342e0cd52171a34be8d8f68e9b3bfcc902794 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Wed Mar 30 15:49:43 2011 +0100 Bug 646231 — Subtitle downloader plugin broken on 2.91.93 Fix another API break in pygobject/GTK+'s GIR. This allows the Subtitle Downloader dialogue to actually open successfully. Closes: bgo#646231 src/plugins/opensubtitles/opensubtitles.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
Comment on attachment 184700 [details] [review] Fix the GDK key constants used in the OpenSubtitles plugin commit 905f245233688aa6b4e9efb5e355ef7554963c13 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Wed Mar 30 16:08:20 2011 +0100 opensubtitles: Fix the GDK key constants used Guess what? Another bug caused by GIR changes for GDK! src/plugins/opensubtitles/opensubtitles.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Comment on attachment 184701 [details] [review] Fix parsing the subtitle file's URI in the OpenSubtitles plugin commit faa342e0cd52171a34be8d8f68e9b3bfcc902794 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Wed Mar 30 15:49:43 2011 +0100 Bug 646231 — Subtitle downloader plugin broken on 2.91.93 Fix another API break in pygobject/GTK+'s GIR. This allows the Subtitle Downloader dialogue to actually open successfully. Closes: bgo#646231 src/plugins/opensubtitles/opensubtitles.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)