After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646231 - Subtitle downloader plugin broken on 2.91.93
Subtitle downloader plugin broken on 2.91.93
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Subtitle Downloader plugin
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-03-30 13:10 UTC by Luis Medinas
Modified: 2011-03-30 19:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix opening the OpenSubtitles dialogue (1.42 KB, patch)
2011-03-30 15:11 UTC, Philip Withnall
committed Details | Review
Fix the GDK key constants used in the OpenSubtitles plugin (959 bytes, patch)
2011-03-30 15:12 UTC, Philip Withnall
committed Details | Review
Fix parsing the subtitle file's URI in the OpenSubtitles plugin (1.01 KB, patch)
2011-03-30 15:13 UTC, Philip Withnall
committed Details | Review

Description Luis Medinas 2011-03-30 13:10:17 UTC
Using totem 2.91.93 from F15 i get this msgs in stdout:

totem
Traceback (most recent call last):
  • File "/usr/lib/totem/plugins/opensubtitles/opensubtitles.py", line 410 in os_show_dialog
    self.os_build_dialog(action)
  • File "/usr/lib/totem/plugins/opensubtitles/opensubtitles.py", line 368 in os_build_dialog
    combobox.set_active_iter(parentit)
  • File "/usr/lib/python2.7/site-packages/gi/types.py", line 44 in function
    return info.invoke(*args)
TypeError: argument 1: Must be Gtk.TreeIter, not tuple

Pressing cancel or search for subtitles doesn't work.
Comment 1 Philip Withnall 2011-03-30 15:11:30 UTC
Created attachment 184699 [details] [review]
Fix opening the OpenSubtitles dialogue

This was caused by a break in the GTK+ GIR file which we hadn't caught up with.

There are another two patches coming to fix crashes/critical failures in the opensubtitles plugin, then I'll request a code freeze break.
Comment 2 Philip Withnall 2011-03-30 15:12:58 UTC
Created attachment 184700 [details] [review]
Fix the GDK key constants used in the OpenSubtitles plugin

This fixes a Python error encountered if one presses a key while the OpenSubtitles dialogue is focussed (and fixes closing the dialogue by pressing the escape key).
Comment 3 Philip Withnall 2011-03-30 15:13:56 UTC
Created attachment 184701 [details] [review]
Fix parsing the subtitle file's URI in the OpenSubtitles plugin

Third and final patch. This one fixes parsing the subtitle file's URI (it's a URI not a path), which actually allows subtitles to be downloaded and loaded correctly.
Comment 4 Philip Withnall 2011-03-30 19:33:50 UTC
Comment on attachment 184699 [details] [review]
Fix opening the OpenSubtitles dialogue

commit faa342e0cd52171a34be8d8f68e9b3bfcc902794
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Mar 30 15:49:43 2011 +0100

    Bug 646231 — Subtitle downloader plugin broken on 2.91.93
    
    Fix another API break in pygobject/GTK+'s GIR. This allows the Subtitle
    Downloader dialogue to actually open successfully.
    
    Closes: bgo#646231

 src/plugins/opensubtitles/opensubtitles.py |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Comment 5 Philip Withnall 2011-03-30 19:33:59 UTC
Comment on attachment 184700 [details] [review]
Fix the GDK key constants used in the OpenSubtitles plugin

commit 905f245233688aa6b4e9efb5e355ef7554963c13
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Mar 30 16:08:20 2011 +0100

    opensubtitles: Fix the GDK key constants used
    
    Guess what? Another bug caused by GIR changes for GDK!

 src/plugins/opensubtitles/opensubtitles.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 6 Philip Withnall 2011-03-30 19:34:08 UTC
Comment on attachment 184701 [details] [review]
Fix parsing the subtitle file's URI in the OpenSubtitles plugin

commit faa342e0cd52171a34be8d8f68e9b3bfcc902794
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Mar 30 15:49:43 2011 +0100

    Bug 646231 — Subtitle downloader plugin broken on 2.91.93
    
    Fix another API break in pygobject/GTK+'s GIR. This allows the Subtitle
    Downloader dialogue to actually open successfully.
    
    Closes: bgo#646231

 src/plugins/opensubtitles/opensubtitles.py |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)