After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646069 - Incorrect versioning for the GIR file
Incorrect versioning for the GIR file
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
2.91.x
Other Linux
: Normal normal
: 2.26
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-03-29 10:09 UTC by Josselin Mouette
Modified: 2013-08-22 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make both namespace and filenames use MAJOR.MINOR versions (3.54 KB, patch)
2013-06-27 01:00 UTC, David E. Narvaez 		none Details | Review

Description Josselin Mouette 2011-03-29 10:09:33 UTC 
The GIR file contains the full version of the brasero tarball. For example:
   typelibs_DATA = BraseroBurn-@BRASERO_VERSION@.typelib

It looks incorrect to me, and it will break the dependencies at each new version of brasero.
I think that instead the version should only change when the ABI does.
Comment 1 Josselin Mouette 2011-10-02 12:34:57 UTC 
Still here in 3.2.0.
Comment 2 David E. Narvaez 2013-06-27 01:00:45 UTC 
Created attachment 247867 [details] [review]
Make both namespace and filenames use MAJOR.MINOR versions

Apparently typelibs cannot have three version numbers, anyways.
Comment 3 Josselin Mouette 2013-06-28 07:55:08 UTC 
Won’t this patch still change the GIR version at every GNOME release, even if the ABI has not changed?
Comment 4 David E. Narvaez 2013-06-29 03:57:56 UTC 
(In reply to comment #3)
> Won’t this patch still change the GIR version at every GNOME release, even if
> the ABI has not changed?

Yes, but it is still better than what there is right now, which does not work at all
Comment 5 Joshua Lock 2013-08-22 16:19:25 UTC 
Thanks for the patch, an alternative patch which addresses this issue has recently been applied from https://bugzilla.gnome.org/show_bug.cgi?id=677732