After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677732 - Use proper typelib versioning
Use proper typelib versioning
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-06-08 21:40 UTC by Michael Biebl
Modified: 2013-08-22 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Use proper typelib versioning (4.21 KB, patch)
2012-06-08 21:44 UTC, Michael Biebl
none Details | Review

Description Michael Biebl 2012-06-08 21:40:05 UTC
brasero changes the typelib version for BraseroBurn and BraseroMedia with each new upstream release, as it encodes the package version.
This looked wrong to me, so I asked around on #gnome-hackers:

<mbiebl> is there some documentation available how typelib versioning should be handled?
<mbiebl> I see that brasero encodes the upstream version number, e.g. BraseroMedia-3.4.1.typelib, which seems wrong
<ebassi> mbiebl: you want the version of the API
<ebassi> mbiebl: so if brasero changes version between 3.4.1 and 3.4.2, you really want that number
<mbiebl> ebassi: so, basically the SOVERSION of the library it references?
<mbiebl> or put differently, if the SOVERSION is bumped, the typelib version should be as well
<ebassi> mbiebl: it depends on policy of the library; e.g. gtk+'s typelib is Gtk-3.0, because the API is changed only with major version bumps
<ebassi> mbiebl: but yes: if you change the API, you bump the soname and you also bump the typelib/gir
<ebassi> given that the typelib reflects the ABI
<mbiebl> ebassi:  brasero uses /usr/lib/libbrasero-media3.so.1.2.0, so I guess 3.1 for the typelib version would look reasonable?
<mbiebl> ebassi: does that sound about right?
<ebassi> mbiebl: yeah
<mbiebl> ok, thanks


Attached is a patch, which uses  brasero-major-version.SOVERSION, i.e. 3.1 atm.
Comment 1 Michael Biebl 2012-06-08 21:44:28 UTC
Created attachment 216001 [details] [review]
[PATCH] Use proper typelib versioning
Comment 2 Joshua Lock 2013-08-22 16:15:55 UTC
Thanks for the patch, applied & pushed to master.