(see bug 641375)

Created attachment 184005 [details] [review]
manager: drop request-privileges stuff

It's all a farce that immediately returns with hardcoded values.

Eventually, we need a better story here (see bug 585614), but for
now, let's not pretend like we're doing something we aren't.

Created attachment 184006 [details] [review]
manager: port to latest shell api

The shell API changed to support multiple
buttons on the log out dialog (see bug 641375)

This commit brings gnome-session up to speed.

We need to make sure we coordinate 

attachment 184006 [details] [review] 

with the changes in bug 641375

Review of attachment 184005 [details] [review]:

That's fine (module detail below). Feel free to commit.

::: gnome-session/gsm-consolekit.c
@@ -138,3 @@
                               1, G_TYPE_POINTER);
 
-        signals [PRIVILEGES_COMPLETED] =

Please also remove PRIVILEGES_COMPLETED from the enum.

Review of attachment 184006 [details] [review]:

There's a small error, but it's all fine otherwise, thanks for working on this! Please commit when you're ready with the shell change.

::: gnome-session/gsm-manager.c
@@ +3085,3 @@
 static void
+gsm_manager_initiate_forced_logout (GsmManager           *manager,
+                                    GsmManagerLogoutType  logout_type)

I'd prefer a less common name, since this is only used by the signal handlers. Maybe simply keep the old name, since it's the common part to all three handlers.

@@ +3156,3 @@
+        manager->priv->shell_end_session_dialog_confirmed_shutdown_id =
+                g_signal_connect (manager->priv->shell,
+                                  "end-session-dialog-confirmed-logout",

Wrong signal name :-)

(In reply to comment #6)
> @@ +3156,3 @@
> +        manager->priv->shell_end_session_dialog_confirmed_shutdown_id =
> +                g_signal_connect (manager->priv->shell,
> +                                  "end-session-dialog-confirmed-logout",
> 
> Wrong signal name :-)
man, no matter how small the patch...

Created attachment 184029 [details] [review]
manager: port to latest shell api

The shell API changed to support multiple
buttons on the log out dialog (see bug 641375)

This commit brings gnome-session up to speed.

Comment on attachment 184029 [details] [review]
manager: port to latest shell api

(transfering patch status from previous iteration over)

So unbelievably¸I never pushed attachment 184029 [details] [review]

freeze break request here: http://mail.gnome.org/archives/release-team/2011-March/msg00209.html