After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641375 - Can't "restart" machine
Can't "restart" machine
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 645432
 
 
Reported: 2011-02-03 17:11 UTC by Bastien Nocera
Modified: 2011-03-23 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
endSessionDialog: hide app list when there are no apps (1.84 KB, patch)
2011-03-21 21:26 UTC, Ray Strode [halfline]
committed Details | Review
endSessionDialog: clean up appearance (3.11 KB, patch)
2011-03-21 21:26 UTC, Ray Strode [halfline]
committed Details | Review
endSessionDialog: make shutdown dialog work like latest mock ups (5.22 KB, patch)
2011-03-21 21:26 UTC, Ray Strode [halfline]
committed Details | Review

Description Bastien Nocera 2011-02-03 17:11:18 UTC
I only get choices like logging out, or shutting down, but not to restart.

I had just setup a dual-boot machine, and was expecting to be able to restart (either as a separate menu item, or have a separate option in the "shut down" dialogue).
Comment 1 Colin Walters 2011-02-03 18:04:11 UTC
Personally on my dual boot system what I've always wanted is a "Reboot Into" dialog that switches the grub default.
Comment 2 Ray Strode [halfline] 2011-02-03 21:23:12 UTC
So at some point there was a Restart button, but it was removed.

I talked to mccann and his feeling is it shouldn't be a separate item, but integrated into the shutdown dialog.  IIRC, though, he said it should be a lot less prominent than the shutdown button.

So the design is tbd, i believe.
Comment 3 Miłosz Kosobucki 2011-03-07 14:15:56 UTC
I can confirm that the absence of restart option is major con. I frequently boot to other OSes and having to manually enter commands in terminal or poweroff than power up with a button is quite cumbersome.
Comment 4 Denis Washington 2011-03-14 10:36:09 UTC
There is a lot of discussion on this in the context of bug #643457. What about just adding a restart option to the currently hidden "Power Off..." dialog (for 3.0 or, if UI freeze completely prevents it, 3.2) and then discuss the possible unhiding of these options in that bug's page?
Comment 5 Ray Strode [halfline] 2011-03-15 20:09:07 UTC
Hi Denis,

That's the current plan. See the mockups here:

https://live.gnome.org/GnomeShell/Design/Whiteboards/SystemStopRestart
Comment 6 Ray Strode [halfline] 2011-03-21 18:11:36 UTC
We'll need gnome-session changes for this, i'll file a bug.
Comment 7 Ray Strode [halfline] 2011-03-21 18:14:48 UTC
filed bug 645432
Comment 8 Ray Strode [halfline] 2011-03-21 21:26:38 UTC
Created attachment 184002 [details] [review]
endSessionDialog: hide app list when there are no apps

We don't want its padding to show up when it shouldn't
be visible.
Comment 9 Ray Strode [halfline] 2011-03-21 21:26:42 UTC
Created attachment 184003 [details] [review]
endSessionDialog: clean up appearance

This commit lines up the app list with the description,
adds spacing between controls of the dialog, and increases
the wrap width of the text.
Comment 10 Ray Strode [halfline] 2011-03-21 21:26:45 UTC
Created attachment 184004 [details] [review]
endSessionDialog: make shutdown dialog work like latest mock ups

This commit adds a restart button to the shutdown dialog and changes
the terminology from Shut Down to Power Off.  This brings things in
line with the latest mockups here:

http://live.gnome.org/GnomeShell/Design/Whiteboards/SystemStopRestart
Comment 11 Ray Strode [halfline] 2011-03-22 02:02:24 UTC
So the session side of this in bug 645432 is reviewed and ready to go.  Would be good if we could land this before the release
Comment 12 Florian Müllner 2011-03-22 02:09:18 UTC
(In reply to comment #11)
> So the session side of this in bug 645432 is reviewed and ready to go.  Would
> be good if we could land this before the release

Did you get approval for string freeze break?
Comment 13 Florian Müllner 2011-03-22 02:13:10 UTC
Review of attachment 184003 [details] [review]:

Sure.
Comment 14 Florian Müllner 2011-03-22 02:13:20 UTC
Review of attachment 184002 [details] [review]:

Looks good.
Comment 15 Florian Müllner 2011-03-22 02:19:47 UTC
Review of attachment 184004 [details] [review]:

I didn't patch gnome-session, so I didn't actually tested the patch, but the code looks reasonable.

::: js/ui/endSessionDialog.js
@@ +74,2 @@
 const shutdownDialogContent = {
+    subject: _("Power Off"),

Looks good, but breaks string break :(

(Likewise the other s/Shutdown/Power off/ changes)
Comment 16 Ray Strode [halfline] 2011-03-22 14:32:08 UTC
So just to follow up:

- I talked to owen and vuntz recently, and they're okay with landing both sides for this release.
- I've requested a string freeze request here:
http://mail.gnome.org/archives/gnome-i18n/2011-March/msg00199.html
Comment 17 kikidong 2011-03-23 17:29:28 UTC
dba02f8f08c7c0499d0c7e4869e95b4c58ea4c90

this commit fixed it , but  guys, unable to logout now.
revert this commit and I was able to logout.

Two hours hard work to figure-out  WTF that cause gnome-session dead lock when logout.
But, I finally found that it's not gnome-session bug , it's gnome-shell.

so, git bisect and I have to blame this commit . But this commit was try to fix this bug......

Hey, what's going on there ?
Comment 18 kikidong 2011-03-23 17:50:31 UTC
OK, here is a small path for Logout problems.

From 27436201464c6eca356b2482b3edfe5ab37aaefe Mon Sep 17 00:00:00 2001
From: microcai <microcai@fedoraproject.org>
Date: Thu, 24 Mar 2011 01:49:12 +0800
Signed-off : microcai microcaicai@gmail.com
Subject: [PATCH] endSessionDialog: fix logout problem

---
 js/ui/endSessionDialog.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js
index c019e2a..3d773e6 100644
--- a/js/ui/endSessionDialog.js
+++ b/js/ui/endSessionDialog.js
@@ -447,7 +447,7 @@ EndSessionDialog.prototype = {
         this._stopTimer();
         DBus.session.emit_signal('/org/gnome/SessionManager/EndSessionDialog',
                                  'org.gnome.SessionManager.EndSessionDialog',
-                                 signal, '', []);
+                                 'Confirmed', '', []);
     },
 
     _onOpened: function() {
-- 
1.7.4.1
Comment 19 Ray Strode [halfline] 2011-03-23 21:25:42 UTC
kikidong, you need to update your gnome-session
Comment 20 Ray Strode [halfline] 2011-03-23 21:27:39 UTC
Just to give more information, the internal protocol between gnome-shell and gnome-session used to send a "Confirmed" signal when the user hit Shutdown.  Now it sends ConfirmedShutdown or ConfirmedReboot.  If using 'Confirmed' works for you, that suggests your gnome-session is out of date
Comment 21 Ionut Biru 2011-03-23 21:32:06 UTC
@Ray, using gnome-session 2.91.92 the problem is still there. Once you hit logout or restart or shutdown the screen just freeze.
Comment 22 Ray Strode [halfline] 2011-03-23 21:34:19 UTC
oh awesome, i didn't push it... see bug 645432