GNOME Bugzilla – Bug 641375
Can't "restart" machine
Last modified: 2011-03-23 21:34:19 UTC
I only get choices like logging out, or shutting down, but not to restart. I had just setup a dual-boot machine, and was expecting to be able to restart (either as a separate menu item, or have a separate option in the "shut down" dialogue).
Personally on my dual boot system what I've always wanted is a "Reboot Into" dialog that switches the grub default.
So at some point there was a Restart button, but it was removed. I talked to mccann and his feeling is it shouldn't be a separate item, but integrated into the shutdown dialog. IIRC, though, he said it should be a lot less prominent than the shutdown button. So the design is tbd, i believe.
I can confirm that the absence of restart option is major con. I frequently boot to other OSes and having to manually enter commands in terminal or poweroff than power up with a button is quite cumbersome.
There is a lot of discussion on this in the context of bug #643457. What about just adding a restart option to the currently hidden "Power Off..." dialog (for 3.0 or, if UI freeze completely prevents it, 3.2) and then discuss the possible unhiding of these options in that bug's page?
Hi Denis, That's the current plan. See the mockups here: https://live.gnome.org/GnomeShell/Design/Whiteboards/SystemStopRestart
We'll need gnome-session changes for this, i'll file a bug.
filed bug 645432
Created attachment 184002 [details] [review] endSessionDialog: hide app list when there are no apps We don't want its padding to show up when it shouldn't be visible.
Created attachment 184003 [details] [review] endSessionDialog: clean up appearance This commit lines up the app list with the description, adds spacing between controls of the dialog, and increases the wrap width of the text.
Created attachment 184004 [details] [review] endSessionDialog: make shutdown dialog work like latest mock ups This commit adds a restart button to the shutdown dialog and changes the terminology from Shut Down to Power Off. This brings things in line with the latest mockups here: http://live.gnome.org/GnomeShell/Design/Whiteboards/SystemStopRestart
So the session side of this in bug 645432 is reviewed and ready to go. Would be good if we could land this before the release
(In reply to comment #11) > So the session side of this in bug 645432 is reviewed and ready to go. Would > be good if we could land this before the release Did you get approval for string freeze break?
Review of attachment 184003 [details] [review]: Sure.
Review of attachment 184002 [details] [review]: Looks good.
Review of attachment 184004 [details] [review]: I didn't patch gnome-session, so I didn't actually tested the patch, but the code looks reasonable. ::: js/ui/endSessionDialog.js @@ +74,2 @@ const shutdownDialogContent = { + subject: _("Power Off"), Looks good, but breaks string break :( (Likewise the other s/Shutdown/Power off/ changes)
So just to follow up: - I talked to owen and vuntz recently, and they're okay with landing both sides for this release. - I've requested a string freeze request here: http://mail.gnome.org/archives/gnome-i18n/2011-March/msg00199.html
dba02f8f08c7c0499d0c7e4869e95b4c58ea4c90 this commit fixed it , but guys, unable to logout now. revert this commit and I was able to logout. Two hours hard work to figure-out WTF that cause gnome-session dead lock when logout. But, I finally found that it's not gnome-session bug , it's gnome-shell. so, git bisect and I have to blame this commit . But this commit was try to fix this bug...... Hey, what's going on there ?
OK, here is a small path for Logout problems. From 27436201464c6eca356b2482b3edfe5ab37aaefe Mon Sep 17 00:00:00 2001 From: microcai <microcai@fedoraproject.org> Date: Thu, 24 Mar 2011 01:49:12 +0800 Signed-off : microcai microcaicai@gmail.com Subject: [PATCH] endSessionDialog: fix logout problem --- js/ui/endSessionDialog.js | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js index c019e2a..3d773e6 100644 --- a/js/ui/endSessionDialog.js +++ b/js/ui/endSessionDialog.js @@ -447,7 +447,7 @@ EndSessionDialog.prototype = { this._stopTimer(); DBus.session.emit_signal('/org/gnome/SessionManager/EndSessionDialog', 'org.gnome.SessionManager.EndSessionDialog', - signal, '', []); + 'Confirmed', '', []); }, _onOpened: function() { -- 1.7.4.1
kikidong, you need to update your gnome-session
Just to give more information, the internal protocol between gnome-shell and gnome-session used to send a "Confirmed" signal when the user hit Shutdown. Now it sends ConfirmedShutdown or ConfirmedReboot. If using 'Confirmed' works for you, that suggests your gnome-session is out of date
@Ray, using gnome-session 2.91.92 the problem is still there. Once you hit logout or restart or shutdown the screen just freeze.
oh awesome, i didn't push it... see bug 645432