After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645354 - window: Export theme variant to X11
window: Export theme variant to X11
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 618492 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-03-21 03:06 UTC by Florian Müllner
Modified: 2011-04-05 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Export theme variant to X11 (7.31 KB, patch)
2011-03-21 03:06 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-03-21 03:06:46 UTC 
The new GNOME standard theme features window decorations which blend in
seamlessly with the window's content. Currently this breaks rather badly 
when applications request a dark variant, as the window manager has no way
to know about the variant. In order to fix this, export the variant as
_GTK_THEME_VARIANT window property when using the X11 backend.
Comment 1 Florian Müllner 2011-03-21 03:06:54 UTC 
Created attachment 183893 [details] [review]
window: Export theme variant to X11

The metacity theme format allows to use colors from the current
GTK+ theme in window decorations. Since GTK+ now gained support
for dark theme variants, window managers using that theme format
(metacity, mutter, compiz via gtk-window-decorator) should be able
to use colors from the correct variant; so in case a variant is
requested, export it in the _GTK_THEME_VARIANT property on
toplevel windows.
Comment 2 Matthias Clasen 2011-03-21 11:36:18 UTC 
Review of attachment 183893 [details] [review]:

Looks fine for master.
Comment 3 Florian Müllner 2011-03-21 14:08:36 UTC 
OK, thanks!

Attachment 183893 [details] pushed as 3032fdc - window: Export theme variant to X11
Comment 4 Bastien Nocera 2011-04-05 18:46:38 UTC 
*** Bug 618492 has been marked as a duplicate of this bug. ***