After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645265 - Add meta_rectangle_adjust
Add meta_rectangle_adjust
Status: RESOLVED WONTFIX
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 645298 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-03-19 22:04 UTC by John Stowers
Modified: 2011-03-20 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add meta_rectangle_adjust (2.31 KB, patch)
2011-03-19 22:05 UTC, John Stowers 		none Details | Review

Description John Stowers 2011-03-19 22:04:59 UTC 
Improves performance in natural placement algorithm described in bug 615378
Comment 1 John Stowers 2011-03-19 22:05:01 UTC 
Created attachment 183820 [details] [review]
Add meta_rectangle_adjust
Comment 2 Owen Taylor 2011-03-20 03:27:38 UTC 
This doesn't seem to me to be a natural rectangle method - it's not a fundamental operation like union and intersection where it's easy to get wrong.

 - Profile
 - Optimize the GJS calling code if profiling shows that up as the bottleneck
 - Test writing in pure JS structures rather than using MetaRectangle to allow the JIT and other optimizations of a modern JS runtime to run
Comment 3 John Stowers 2011-03-20 03:53:41 UTC 
(In reply to comment #2)
> This doesn't seem to me to be a natural rectangle method - it's not a
> fundamental operation like union and intersection where it's easy to get wrong.

Fair point.

> 
>  - Profile
>  - Optimize the GJS calling code if profiling shows that up as the bottleneck

Any pointers? All I found was this - http://blog.fishsoup.net/2010/05/26/measuring-gnome-shell-performance/

>  - Test writing in pure JS structures rather than using MetaRectangle to allow
> the JIT and other optimizations of a modern JS runtime to run

Thanks.
Comment 4 Florian Müllner 2011-03-20 14:21:38 UTC 
*** Bug 645298 has been marked as a duplicate of this bug. ***
Comment 5 Florian Müllner 2011-03-20 17:25:27 UTC 
*** Bug 645298 has been marked as a duplicate of this bug. ***