After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644818 - Use (modified) gedit tab label instead of our current custom code.
Use (modified) gedit tab label instead of our current custom code.
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755388
 
 
Reported: 2011-03-15 12:44 UTC by Alexandre Mazari
Modified: 2018-08-03 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gedit tab label instead of our current custom code. (21.69 KB, patch)
2011-03-15 12:45 UTC, Alexandre Mazari 		reviewed Details | Review

Description Alexandre Mazari 2011-03-15 12:44:53 UTC 
Extract tab label generation from EphyNotebook and replace it with a widget
imported from GEdit. The local version of it was modified to remove any gedit
specifics. Also it exposes more properties, so make it easy to use with g_binding.
Comment 1 Alexandre Mazari 2011-03-15 12:45:00 UTC 
Created attachment 183421 [details] [review]
Use gedit tab label instead of our current custom code.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2011-03-15 13:06:32 UTC 
Review of attachment 183421 [details] [review]:

Cool, does it change much visually?

::: embed/ephy-web-view.c
@@ +1358,3 @@
+ * EphyWebView:visibility:
+ *
+ *

docs!

::: lib/widgets/Makefile.am
@@ +24,3 @@
 	gedit-overlay-child.c			\
+	gedit-overlay-child.h		\
+	gedit-tab-label.c			\

indent!
Comment 3 Xan Lopez 2012-07-31 22:32:08 UTC 
Comment on attachment 183421 [details] [review]
Use gedit tab label instead of our current custom code.

This is not a bad idea. It needs:

- Updating to git master.
- Either convince gedit to make this shareable or rename it to EphyTabLabel.
Comment 4 William Jon McCann 2014-01-02 14:44:25 UTC 
At this point I think we really want to add better "tab" widgets to GTK instead.
Comment 5 GNOME Infrastructure Team 2018-08-03 19:29:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/145.