After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644279 - [patch] port watcher-x11 to GDBus
[patch] port watcher-x11 to GDBus
Status: RESOLVED DUPLICATE of bug 622880
Product: gnome-screensaver
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-09 07:09 UTC by Saleem Abdulrasool
Modified: 2013-01-16 17:32 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4

Attachments
0002-saver-port-watcher-to-GDBus.patch (11.91 KB, patch)
2011-03-09 07:09 UTC, Saleem Abdulrasool 		none Details | Review
0002-saver-port-watcher-to-GDBus.patch (13.00 KB, patch)
2011-03-10 06:17 UTC, Saleem Abdulrasool 		none Details | Review

Description Saleem Abdulrasool 2011-03-09 07:09:20 UTC 
This continues the work of moving gnome-screensaver to GDBus.  This migrates the watcher implementation to use GDBus rather than dbus-glib.
Comment 1 Saleem Abdulrasool 2011-03-09 07:09:43 UTC 
Created attachment 182925 [details] [review]
0002-saver-port-watcher-to-GDBus.patch
Comment 2 Christian Persch 2011-03-09 10:23:39 UTC 
I think it would be easier to use a GDBusProxy here instead of calling Properties.Get yourself, and listening to all those signals by hand.

In the on_* callbacks, you do things like

+        g_variant_get (parameters, "(u)", &status);

without first checking that the variant has, in fact, this signature. I think for safety you should check that.
Comment 3 Saleem Abdulrasool 2011-03-10 06:17:47 UTC 
Created attachment 183043 [details] [review]
0002-saver-port-watcher-to-GDBus.patch

Yeah, good point about the safety.  Updated the patch.
Comment 4 William Jon McCann 2013-01-16 17:28:34 UTC 
I think this is better all done at once. Going to dup the bug.

*** This bug has been marked as a duplicate of bug 622880 ***