After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622880 - Migrate from dbus-glib to glib's GDBus
Migrate from dbus-glib to glib's GDBus
Status: RESOLVED OBSOLETE
Product: gnome-screensaver
Classification: Deprecated
Component: general
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
: 644279 644280 644281 644282 (view as bug list)
Depends on:
Blocks: 622871
 
 
Reported: 2010-06-27 10:35 UTC by André Klapper
Modified: 2014-08-20 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-saver-port-watcher-to-GDBus.patch (13.00 KB, patch)
2013-01-23 06:06 UTC, Saleem Abdulrasool 		none Details | Review
0002-saver-port-listener-to-GDBus.patch (72.84 KB, patch)
2013-01-23 06:06 UTC, Saleem Abdulrasool 		none Details | Review
0003-build-no-longer-link-against-dbus-glib.patch (813 bytes, patch)
2013-01-23 06:06 UTC, Saleem Abdulrasool 		none Details | Review
0004-build-remove-unused-DBUS-references.patch (2.75 KB, patch)
2013-01-23 06:07 UTC, Saleem Abdulrasool 		none Details | Review

Description André Klapper 2010-06-27 10:35:09 UTC 
For GLib 2.25.5 GDBus D-Bus support was merged, providing an API to replace dbus-glib.

See http://library.gnome.org/devel/gio/unstable/gdbus.html and http://library.gnome.org/devel/gio/unstable/ch28.html .

According to a quick grep this module seems to use dbus-glib:

./gnome-screensaver/configure.ac:        dbus-glib-1 >= $DBUS_REQUIRED_VERSION
./gnome-screensaver/configure.ac:        dbus-glib-1 >= $DBUS_REQUIRED_VERSION)
Comment 1 William Jon McCann 2013-01-16 17:28:34 UTC 
*** Bug 644279 has been marked as a duplicate of this bug. ***
Comment 2 William Jon McCann 2013-01-16 17:29:37 UTC 
*** Bug 644280 has been marked as a duplicate of this bug. ***
Comment 3 William Jon McCann 2013-01-16 17:30:14 UTC 
*** Bug 644281 has been marked as a duplicate of this bug. ***
Comment 4 William Jon McCann 2013-01-16 17:30:35 UTC 
*** Bug 644282 has been marked as a duplicate of this bug. ***
Comment 5 William Jon McCann 2013-01-16 17:32:00 UTC 
Saleem, can you add all of your patches here please?
Comment 6 Saleem Abdulrasool 2013-01-22 03:07:29 UTC 
Sure, I just need to dig them up, and make sure that they still apply to master.
Comment 7 Saleem Abdulrasool 2013-01-23 06:06:18 UTC 
Created attachment 234165 [details] [review]
0001-saver-port-watcher-to-GDBus.patch
Comment 8 Saleem Abdulrasool 2013-01-23 06:06:38 UTC 
Created attachment 234166 [details] [review]
0002-saver-port-listener-to-GDBus.patch
Comment 9 Saleem Abdulrasool 2013-01-23 06:06:58 UTC 
Created attachment 234167 [details] [review]
0003-build-no-longer-link-against-dbus-glib.patch
Comment 10 Saleem Abdulrasool 2013-01-23 06:07:21 UTC 
Created attachment 234168 [details] [review]
0004-build-remove-unused-DBUS-references.patch
Comment 11 Saleem Abdulrasool 2013-01-23 06:10:22 UTC 
These are rebased to current master.  I've not really tested them much beyond a compile cycle after the rebasing.  Though, fortunately, the changes weren't too extensive.  IIRC, everything except the message bit I had tested previously (not that I really consider that valid given the patchset was rebased).
Comment 12 Bastien Nocera 2014-08-20 20:23:41 UTC 
The screen lock is now implemented directly in gnome-shell, not in
gnome-screensaver (as it was with older version of GNOME 3 and GNOME 2.x).

If the reported problems persists in recent versions of GNOME, please file a new bug against gnome-shell with the "lock-screen" component selected.

If your installation is an older version of GNOME that cannot be upgraded (such as an enterprise version), please use the appropriate support mechanism from your vendor, or your distribution instead.