After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643923 - Should not use markup for GtkFrame's label
Should not use markup for GtkFrame's label
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks: 670650
 
 
Reported: 2011-03-05 00:23 UTC by Gabor Kelemen
Modified: 2013-09-13 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gabor Kelemen 2011-03-05 00:23:10 UTC
As spotted in bug #643707, Glade currently generates GtkFrame widgets using the use-markup property on their label and putting the label between <b> tags by default. 

Glade should use Pango attributes to make the label text bold. 

<b>This results in translatable strings with unnecessary markup around them, and annoyed translators reporting bugs like the one referenced.</b>

The error comes from glade_gtk_frame_post_create() in plugins/gtk+/glade-gtk.c
Comment 1 Daniel Mustieles 2013-09-13 14:48:27 UTC
Hi! We've been talking about this same issue in another bug (https://bugzilla.gnome.org/show_bug.cgi?id=670650).

Since there is a GNOME Goal to remove markup from .ui files, it makes no sense that files generated by glade include that markup... could be possible to change this behaviour in glade?
Comment 2 Juan Pablo Ugarte 2013-09-13 20:19:17 UTC
(In reply to comment #1)
> Hi! We've been talking about this same issue in another bug
> (https://bugzilla.gnome.org/show_bug.cgi?id=670650).
> 
> Since there is a GNOME Goal to remove markup from .ui files, it makes no sense
> that files generated by glade include that markup... could be possible to
> change this behaviour in glade?

Are you suggesting we remove markup support from Glade?

I agree that its better not to use markup in general so I will make sure glade is not generating unnecessary markup by default.
Comment 3 Daniel Mustieles 2013-09-13 20:40:47 UTC
(In reply to comment #2)
> Are you suggesting we remove markup support from Glade?

No, I was just suggesting to use Pango attributes in the .ui files. Take a look into this commit to see what I mean: https://git.gnome.org/browse/pitivi/commit/?id=9642092edb207c7eb8dd05b05c6a3471a058a014

Bold and italics are interesting and, sometimes, neccesary, so removing them completely wouldn't make people happy, but changing the generated code would make happy both developers and translators ;-)
Comment 4 Juan Pablo Ugarte 2013-09-13 21:11:36 UTC
Fixed in master, I will also push it to glade-3-16 before monday