After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643707 - Please remove unnecessary markup from .ui files
Please remove unnecessary markup from .ui files
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: git
git master
Other Linux
: Normal normal
: ---
Assigned To: James Liggett
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-02 18:58 UTC by Gabor Kelemen
Modified: 2011-03-05 00:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Simple patch to remove unnecessary markup (24.05 KB, patch)
2011-03-02 18:58 UTC, Gabor Kelemen
none Details | Review
Do the same for class-gen plugin (1.70 KB, patch)
2011-03-02 18:59 UTC, Gabor Kelemen
none Details | Review
And for the mk-project plugin (855 bytes, patch)
2011-03-02 19:01 UTC, Gabor Kelemen
none Details | Review

Description Gabor Kelemen 2011-03-02 18:58:32 UTC
Created attachment 182288 [details] [review]
Simple patch to remove unnecessary markup

A nice bunch of unnecessary markup crawled back to several Anjuta plugins, mostly into git. Please remove these, and make translators' life easier.
Comment 1 Gabor Kelemen 2011-03-02 18:59:35 UTC
Created attachment 182290 [details] [review]
Do the same for class-gen plugin
Comment 2 Gabor Kelemen 2011-03-02 19:01:22 UTC
Created attachment 182292 [details] [review]
And for the mk-project plugin
Comment 3 Johannes Schmid 2011-03-03 15:24:15 UTC
Thanks for the patches!

I would be even more happy if you could use "git format-patch" next time instead because it retains the author information and I don't have to enter that manually.
Comment 4 James Liggett 2011-03-04 23:11:20 UTC
I know this is a bit late, but...

Just patching the ui files to remove the markup from them doesn't really solve the underlying problem: When you create a frame or expander with glade, it uses markup to make the labels bold by default. So this problem is going to come up again any time someone make a new frame or expander in their ui. And I'm almost certain that by the time that new code moves to git, we will have long forgotten about this bug, and we'll be hearing about it again. 

I suggest that you ask the glade devs to use font attributes instead of markup to make labels bold. That would solve your problems for good, and we developers wouldn't have to worry about this again, so we both win.
Comment 5 Gabor Kelemen 2011-03-05 00:27:43 UTC
I don't see current Glade adding markup to expanders, but for frames you are right. I just filed bug #643923, thanks for the observation!