After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643163 - use same background as gdm
use same background as gdm
Status: RESOLVED NOTABUG
Product: gnome-screensaver
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
: 645073 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-24 04:53 UTC by Matthias Clasen
Modified: 2011-03-17 20:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2011-02-24 04:53:35 UTC
We should have a the same background in gdm as in the lock dialog; either hardcode the default background, or use a separate key for it to keep it separate from the users background in the session.
Comment 1 André Klapper 2011-03-03 20:52:17 UTC
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]
Comment 2 Ray Strode [halfline] 2011-03-17 17:43:02 UTC
So there are a few problems with a separate key

1) It's not just one separate key, but is 7 that together define how the background is rendered.

2) gdm doesn't draw the background itself, gnome-settings-daemon does.  gnome-settings-daemon doesn't run in a "GDM mode" or anything so it wouldn't know to use the 7 different keys (and it uses the key through an abstracted api in gnome-desktop, anyway, so we'd need new api to tell gnome-desktop to use the new keys)

But, it turns out the screensaver and the login screen already use the same background, though, because screensaver has this code:

gs-manager.c-        /* FIXME: we need to bind system settings instead of user but
gs-manager.c-         *        that's currently impossible, not implemented yet.
gs-manager.c-         *        Hence, reset to system default values.
gs-manager.c-         */
gs-manager.c-        /* TODO: Ideally we would like to bind some other key, screensaver-specific. */
gs-manager.c-        settings = g_settings_new ("org.gnome.desktop.background");
gs-manager.c-
gs-manager.c:        g_settings_delay (settings);
gs-manager.c-
gs-manager.c-        keys = g_settings_list_keys (settings);
gs-manager.c-        for (k = keys; *k; k++) {
gs-manager.c-                g_settings_reset (settings, *k);
gs-manager.c-        }
gs-manager.c-        g_strfreev (keys);

the g_settings_delay() call means no changes to org.gnome.desktop.background will get propagated to the users session, and then the rest of the code forces schema defaults (or the administrator overrides).

So we're actually good enough for now, I think.  It would be good if we had a better UI story here for admins, and indeed a more fleshed out admin story overall in gsettings/dconf world, but those are separate issues.
Comment 3 Ray Strode [halfline] 2011-03-17 20:47:35 UTC
*** Bug 645073 has been marked as a duplicate of this bug. ***