After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642953 - interactive search widget is offscreen when maximized
interactive search widget is offscreen when maximized
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 343083 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-22 11:26 UTC by Stefano Teso
Modified: 2011-02-26 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.51 KB, patch)
2011-02-23 12:23 UTC, Stefano Teso
accepted-commit_now Details | Review

Description Stefano Teso 2011-02-22 11:26:58 UTC
When nautilus is in maximized/fullscreen state, the interactive search window is not displayed at all -- i.e., it is placed outside of the visible screen area.

Note that the list view (GtkTreeView) works correctly.
Comment 1 Stefano Teso 2011-02-23 12:23:19 UTC
Created attachment 181690 [details] [review]
patch

The attached patch mimics the code in gtktreeview.c. The interactive search window is now placed correctly (i.e., _inside_ the screen) when the nautilus window is maximized.
Comment 2 Cosimo Cecchi 2011-02-23 19:21:36 UTC
Review of attachment 181690 [details] [review]:

The patch looks good, except for that glitch below; It still doesn't work as expected though, the typeahead search widget is only shown the first time we open a window, and not the following times I try to trigger it.
As the regression is in master too, I am opening a new bug for that, and you can commit this patch after you remove that whitespace change, closing this one.

::: eel/eel-editable-label.c
@@ -1979,2 +1979,1 @@
   g_assert (EEL_IS_EDITABLE_LABEL (label));
-  

This spurious change should not be here...
Comment 3 Cosimo Cecchi 2011-02-23 19:24:42 UTC
(In reply to comment #2)

> As the regression is in master too, I am opening a new bug for that

That's bug 643114
Comment 4 Stefano Teso 2011-02-26 10:34:14 UTC
Committed as 089315b56f78113bd26d18bb40d0132b84954ebe.
Comment 5 Stefano Teso 2011-02-26 16:27:54 UTC
*** Bug 343083 has been marked as a duplicate of this bug. ***