After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642854 - jsapi-util: Remove usage of deprecated JS_GetScopeChain
jsapi-util: Remove usage of deprecated JS_GetScopeChain
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
: 642762 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-21 06:44 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-05-04 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
jsapi-util: Remove usage of deprecated JS_GetScopeChain (1.42 KB, patch)
2011-02-21 06:44 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-02-21 06:44:15 UTC
Upstream bugs:

  https://bugzilla.mozilla.org/show_bug.cgi?id=631135
  https://bugzilla.mozilla.org/show_bug.cgi?id=632064
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-02-21 06:44:17 UTC
Created attachment 181438 [details] [review]
jsapi-util: Remove usage of deprecated JS_GetScopeChain

JS_GetScopeChain is on the fast-track to being deprecated, so
replace this with the debugger API JS_GetFrameScopeChain.

See upstream bugs:
  https://bugzilla.mozilla.org/show_bug.cgi?id=631135
  https://bugzilla.mozilla.org/show_bug.cgi?id=632064
Comment 2 Havoc Pennington 2011-02-21 19:37:55 UTC
The patch looks OK to me (without verifying the docs and usage of those debug APIs), but maybe gjs_explain_scope() should just be removed, since it's more or less a debugging API itself. I was using it to figure out some weird problems related to having multiple contexts and global objects.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-02-21 20:51:34 UTC
*** Bug 642762 has been marked as a duplicate of this bug. ***
Comment 4 Colin Walters 2011-05-04 18:48:55 UTC
An equivalent fix for this landed in commit 333c484c .