After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642762 - [patch] xulrunner2: conditionally adapt to JS_GetScopeChain removal
[patch] xulrunner2: conditionally adapt to JS_GetScopeChain removal
Status: RESOLVED DUPLICATE of bug 642854
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal blocker
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-19 16:10 UTC by Marc-Antoine Perennou
Modified: 2011-02-21 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
conditionally adapt to JS_GetScopeChain removal (2.30 KB, patch)
2011-02-19 16:11 UTC, Marc-Antoine Perennou 		accepted-commit_now Details | Review

Description Marc-Antoine Perennou 2011-02-19 16:10:17 UTC 
Adapt to new API breakage:
http://hg.mozilla.org/mozilla-central/rev/b0bf06306261
Comment 1 Marc-Antoine Perennou 2011-02-19 16:11:44 UTC 
Created attachment 181326 [details] [review]
conditionally adapt to JS_GetScopeChain removal
Comment 2 Colin Walters 2011-02-19 16:52:15 UTC 
Review of attachment 181326 [details] [review]:

::: gjs/jsapi-util.c
@@ +915,3 @@
     g_free(debugstr);
 
+    parent = JS_GetGlobalForScopeChain(context);

I probably would have inlined the #ifdef here since there's only one caller rather than adding to compat.h, but it's fine either way.
Comment 3 Marc-Antoine Perennou 2011-02-19 16:55:21 UTC 
I thought It'd be handier when removing xulrunner 1.9 support later on
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-02-21 20:51:34 UTC 
This is an incorrect fix. I have a more proper fix in https://bugzilla.gnome.org/show_bug.cgi?id=642854 but havoc suggested that removing the fragile method might be better.

Marking that bug as a duplicate of this.

*** This bug has been marked as a duplicate of bug 642854 ***