GNOME Bugzilla – Bug 642189
Remove window filtering for dash item right click menu
Last modified: 2011-02-14 22:07:40 UTC
From https://bugzilla.gnome.org/show_bug.cgi?id=639567#c6 the whole "filter windows on right click on a dash item" thing isn't working: * Having everything change when you click on the menu is really distracting and confusing * When you go over the menu, having things prelight in the menu, and then also change elsewhere on the screen means you don't know where to look * The highlight behavior with a black box over the workspace area is just weird - it was a hack that sort of worked with how we drew the workspace at the time. * In a multiple workspaces scenario, showing only the app windows from this workspace is confusing, but pulling them all together without any context is also weird So we want to just remove it. I'll file a separate bug for that rather than repurposing this one. I think it's best to be fairly aggressive about removing code - there is so much going on in the workspace window positioning code that code portions that aren't being used will rot very quickly, and I think it's unlikely we'd want to bring this behavior back in anything like its current form.
Created attachment 180732 [details] [review] AppWellMenu: Remove window filtering Don't filter and highlight windows when opening the menu as this turned out to be distracting and confusing. --- Well so lets kill it ...
Review of attachment 180732 [details] [review]: Looks good as far as it goes, but I think you should strip out Workspace.setShowOnlyWindows and the implementation of that as well. ::: js/ui/appDisplay.js @@ -457,3 @@ - highlightWindow: function(metaWindow) { - if (this._didActivateWindow) I don't see any reason to keep didActivateWindow around - it's about not undoing the filtering when zooming into a desktop.
Created attachment 180778 [details] [review] AppWellMenu: Remove window filtering Don't filter and highlight windows when opening the menu as this turned out to be distracting and confusing.
Review of attachment 180778 [details] [review]: ::: js/ui/appDisplay.js @@ -466,3 @@ activateWindow: function(metaWindow) { if (metaWindow) { this._didActivateWindow = true; This needed to be removed too (so just search through the file for didActivateWindow) ::: js/ui/workspace.js @@ -614,3 @@ }, - setShowOnlyWindows: function(showOnlyWindows, reposition) { There's a lot more to the implementation than this.
Created attachment 180789 [details] [review] AppWellMenu: Remove window filtering Don't filter and highlight windows when opening the menu as this turned out to be distracting and confusing. --- Should be complete this time unless I missed anything again.
Review of attachment 180789 [details] [review]: Looks very close ::: js/ui/workspace.js @@ +850,2 @@ if (this._reservedSlot) + clones.push(this._reservedSlot); you didn't copy this._windows, so now you modified it.
Created attachment 180790 [details] [review] AppWellMenu: Remove window filtering Don't filter and highlight windows when opening the menu as this turned out to be distracting and confusing.
Created attachment 180858 [details] [review] AppWellMenu: Remove window filtering Don't filter and highlight windows when opening the menu as this turned out to be distracting and confusing. --- *) Don't sort this._windows, but a copy of it
Review of attachment 180858 [details] [review]: Both fixes to use .slice() look good
Attachment 180858 [details] pushed as c2ae95f - AppWellMenu: Remove window filtering