Created attachment 178353 [details] [review]
AppWellMenu: Temporary switch workspace on highlight

In order to be able to highlight windows on a workspace other than
the current one we have to temporary switch to it.

In case the use decided to close the menu we restore the workspace
the user started from.

(In reply to comment #1)
> Created an attachment (id=178353) [details] [review]
> AppWellMenu: Temporary switch workspace on highlight

Maybe filtering / highlighting previews in the (yet-to-be-written) vertical-workspace-switcher is less intrusive/busy?

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=178353) [details] [review] [details] [review]
> > AppWellMenu: Temporary switch workspace on highlight
> 
> Maybe filtering / highlighting previews in the (yet-to-be-written)
> vertical-workspace-switcher is less intrusive/busy?

Not sure about that .. in case you have multiple windows open to be really visible in the vertical switcher but OTOH you have the title in the menu where your focus is ...

(In reply to comment #1)
> Created an attachment (id=178353) [details] [review]
> AppWellMenu: Temporary switch workspace on highlight
> 
> In order to be able to highlight windows on a workspace other than
> the current one we have to temporary switch to it.
> 
> In case the use decided to close the menu we restore the workspace
> the user started from.

What happens if there are windows on multiple desktops? Maybe the filtered view of app windows shouldn't correspond to a "desktop"?

It would make more sense than blank results.

Review of attachment 178353 [details] [review]:

Discussed this with Jon at some length. What we decided was that the whole "filter windows on right click thing" wasn't working:

 * Having everything change when you click on the menu is really distracting and confusing
 * When you go over the menu, having things prelight in the menu, and then also change elsewhere on the screen means you don't know where to look
 * The highlight behavior with a black box over the workspace area is just weird - it was a hack that sort of worked with how we drew the workspace at the time.
 * In a multiple workspaces scenario, not showing all windows on different workspaces is weird, but pulling them all together without any context is also weird

So we want to just remove it. I'll file a separate bug for that rather than repurposing this one.

Removal filed as bug 642189