After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642059 - kill off shell-drawing
kill off shell-drawing
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-10 19:46 UTC by Dan Winship
Modified: 2011-02-14 14:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-drawing: remove shell_draw_box_pointer() (6.05 KB, patch)
2011-02-10 19:46 UTC, Dan Winship 		committed Details | Review
shell-drawing: remove (3.35 KB, patch)
2011-02-10 19:46 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-02-10 19:46:11 UTC 
depends on bug 642058
Comment 1 Dan Winship 2011-02-10 19:46:14 UTC 
Created attachment 180614 [details] [review]
shell-drawing: remove shell_draw_box_pointer()

This was originally done in C because it used cairo, but that can be
done from JS now. Since it was only used by altTab.js, move it there.
Comment 2 Dan Winship 2011-02-10 19:46:16 UTC 
Created attachment 180615 [details] [review]
shell-drawing: remove

Remove shell-drawing.[ch], which now only contained
shell_draw_clock(), which hadn't been used since the sidebar went
away.
Comment 3 Colin Walters 2011-02-11 05:04:07 UTC 
Review of attachment 180615 [details] [review]:

Looks straightforward enough.
Comment 4 Owen Taylor 2011-02-12 18:29:35 UTC 
Review of attachment 180614 [details] [review]:

Looks like a correct translation from C to JS.

(Though the removal of the assert_not_reached here is fine - had little important function, does remind me that I'd like Lang.assert() or even a GJS builtin ... sometimes you *do* want to assert.)
Comment 5 Dan Winship 2011-02-14 14:39:41 UTC 
Attachment 180614 [details] pushed as 0c0e2cc - shell-drawing: remove shell_draw_box_pointer()
Attachment 180615 [details] pushed as 688b969 - shell-drawing: remove