After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642058 - lookingGlass: fix red border drawing in the inspector, port to JS
lookingGlass: fix red border drawing in the inspector, port to JS
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-10 19:45 UTC by Dan Winship
Modified: 2011-02-10 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lookingGlass: fix red border drawing in the inspector, port to JS (4.83 KB, patch)
2011-02-10 19:45 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2011-02-10 19:45:08 UTC
Some recent painting-efficiency fix broke the inspector, which
accidentally depended on things getting repainted too often, and so
was failing to highlight things properly now. A simple queue_redraw()
fixes this, but while I was there, I decided to port the drawing hook
to JS as well, since all the necessary parts of cogl work fine from
JS.
Comment 1 Dan Winship 2011-02-10 19:45:10 UTC
Created attachment 180613 [details] [review]
lookingGlass: fix red border drawing in the inspector, port to JS
Comment 2 Colin Walters 2011-02-10 20:05:01 UTC
Review of attachment 180613 [details] [review]:

Looks OK to me.
Comment 3 Dan Winship 2011-02-10 21:05:21 UTC
Attachment 180613 [details] pushed as 475c360 - lookingGlass: fix red border drawing in the inspector, port to JS