After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641566 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: gnome-menus
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gnome-menus dummy account
gnome-menus dummy account
Depends on:
Blocks: 641445
 
 
Reported: 2011-02-04 23:04 UTC by Craig Keogh
Modified: 2011-02-05 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Honor aclocal flags (613 bytes, patch)
2011-02-04 23:05 UTC, Craig Keogh
none Details | Review
Remove configure.ac ACLOCAL_FLAGS, now in Makefile.am (742 bytes, patch)
2011-02-04 23:22 UTC, Craig Keogh
none Details | Review

Description Craig Keogh 2011-02-04 23:04:25 UTC
I'm building gnome-menus via JHBuild. gnome-menus builds
successfully. If upstream then updates configure.ac, then I run 'make', which
attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/gnome-menus/missing --run aclocal-1.11 -I m4
configure.ac:30: warning: macro `AM_GLIB_GNU_GETTEXT' not found in library
configure.ac:3: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-menus
 cd . && /bin/sh /home/Oxyde/gnome/gnome-menus/missing --run automake-1.11 --foreign
configure.ac:3: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-menus
libmenu/Makefile.am:57: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
make: *** [Makefile.in] Error 1
Comment 1 Craig Keogh 2011-02-04 23:05:46 UTC
Created attachment 180133 [details] [review]
Honor aclocal flags
Comment 2 Craig Keogh 2011-02-04 23:22:22 UTC
Created attachment 180134 [details] [review]
Remove configure.ac ACLOCAL_FLAGS, now in Makefile.am


This optional patch removes the ACLOCAL_FLAGS support in configure.ac.
ACLOCAL_FLAGS support is in Makefile.am as per attachment 180133 [details] [review].
See bug 640883 comment 4 by Christian Persch for more information.
Comment 3 Vincent Untz 2011-02-05 00:01:46 UTC
Craig: can you "git pull" before filing the bugs? ;-) http://git.gnome.org/browse/gnome-menus/commit/?id=9792ac69297dc003f5ba4d9461e15874ac1a6908