After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641476 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other All
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks: 641445
 
 
Reported: 2011-02-04 11:05 UTC by Craig Keogh
Modified: 2011-03-16 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Honor aclocal flags (554 bytes, patch)
2011-02-04 11:06 UTC, Craig Keogh 		committed Details | Review

Description Craig Keogh 2011-02-04 11:05:27 UTC 
I'm building gvfs via JHBuild. gvfs builds successfully. If upstream then updates configure.ac, then I run 'make', which attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/gvfs/missing --run aclocal-1.11 
configure.ac:70: warning: macro `AM_GLIB_GNU_GETTEXT' not found in library
 cd . && /bin/sh /home/Oxyde/gnome/gvfs/missing --run automake-1.11 --gnu
daemon/Makefile.am:33: `%'-style pattern rules are a GNU make extension
daemon/Makefile.am:40: `%'-style pattern rules are a GNU make extension
metadata/Makefile.am:56: `%'-style pattern rules are a GNU make extension
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/gvfs/missing --run autoconf
configure.ac:70: error: possibly undefined macro: AM_GLIB_GNU_GETTEXT
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
make: *** [configure] Error 1
Comment 1 Craig Keogh 2011-02-04 11:06:18 UTC 
Created attachment 180070 [details] [review]
Honor aclocal flags
Comment 2 Tomas Bzatek 2011-03-16 15:48:24 UTC 
Committed, thanks.

commit 8bfd933e98c74af026659213dd53e9fd0c41358e
Author: Craig Keogh <cskeogh@adam.com.au>
Date:   Wed Mar 16 16:47:19 2011 +0100

    build: Honor ACLOCAL_FLAGS
    
    https://bugzilla.gnome.org/show_bug.cgi?id=641476