After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641450 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Dan Williams
Dan Williams
: 639701 (view as bug list)
Depends on:
Blocks: 641445
 
 
Reported: 2011-02-04 08:11 UTC by Craig Keogh
Modified: 2011-02-24 01:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Honor aclocal flags (628 bytes, patch)
2011-02-04 08:14 UTC, Craig Keogh 		none Details | Review
Remove configure.ac ACLOCAL_FLAGS, now in Makefile.am (919 bytes, patch)
2011-02-04 08:19 UTC, Craig Keogh 		none Details | Review

Description Craig Keogh 2011-02-04 08:11:50 UTC 
I'm building NetworkManager via JHBuild. NetworkManager builds
successfully. If upstream then updates configure.in, then I run 'make', which
attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/NetworkManager/missing --run aclocal-1.11 -I m4
configure.ac:66: warning: macro `AM_GLIB_GNU_GETTEXT' not found in library
 cd . && /bin/sh /home/Oxyde/gnome/NetworkManager/missing --run automake-1.11 --gnu
callouts/Makefile.am:72: `%'-style pattern rules are a GNU make extension
docs/Makefile.am:25: wildcard $(top_srcdir: non-POSIX variable name
docs/Makefile.am:25: (probably a GNU make extension)
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/NetworkManager/missing --run autoconf
configure.ac:66: error: possibly undefined macro: AM_GLIB_GNU_GETTEXT
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
make: *** [configure] Error 1
Comment 1 Craig Keogh 2011-02-04 08:14:36 UTC 
Created attachment 180048 [details] [review]
Honor aclocal flags
Comment 2 Craig Keogh 2011-02-04 08:19:27 UTC 
Created attachment 180049 [details] [review]
Remove configure.ac ACLOCAL_FLAGS, now in Makefile.am


This patch removes the ACLOCAL_FLAGS support in configure.ac. ACLOCAL_FLAGS support is in Makefile.am as per attachment 180045 [details] [review]. See bug 640883 comment 4 Christian Persch for more information.
Comment 3 Craig Keogh 2011-02-04 11:10:09 UTC 
(In reply to comment #2)
> support is in Makefile.am as per attachment 180045 [details] [review].

Sorry, I meant attachment 180048 [details] [review].
Comment 4 Dan Williams 2011-02-23 19:02:52 UTC 
5dbaec5f84b1cc00745edb3a9d561db9d2cd0197

Thanks!  The Makefile.am part was already committed as a partial fix for bug 640896.
Comment 5 Dan Williams 2011-02-24 01:29:13 UTC 
*** Bug 639701 has been marked as a duplicate of this bug. ***