After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641095 - MonoDevelop branded images in setup wizard (msi)
MonoDevelop branded images in setup wizard (msi)
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
1.9.3
Other Windows
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-01 00:36 UTC by Matt Sturgeon
Modified: 2011-02-07 00:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot showing how they're used (90.02 KB, image/png)
2011-02-01 03:00 UTC, Gabriel Burt
  Details
Patch to add banshee branded MSI bitmaps (235.95 KB, patch)
2011-02-01 07:46 UTC, Matt Sturgeon
needs-work Details | Review
XCF of new dlgbmp.bmp (619.43 KB, image/x-xcf)
2011-02-01 07:49 UTC, Matt Sturgeon
  Details
XCF of new bannrbmp.bmp (95.27 KB, image/x-xcf)
2011-02-01 07:51 UTC, Matt Sturgeon
  Details
New: 2nd Patch to add banshee branded MSI bitmaps (223.55 KB, patch)
2011-02-02 13:12 UTC, Matt Sturgeon
none Details | Review
XCF of new bannrbmp.bmp (103.61 KB, application/octet-stream)
2011-02-02 13:13 UTC, Matt Sturgeon
  Details
New: 3nd(now JPEG format) Patch to add banshee branded MSI bitmaps (147.26 KB, patch)
2011-02-03 19:22 UTC, Matt Sturgeon
needs-work Details | Review
Candidate bannrbmp.jpg (11.89 KB, image/jpeg)
2011-02-03 23:12 UTC, Matt Sturgeon
  Details
Patch 0004: Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format. (144.33 KB, patch)
2011-02-05 00:56 UTC, Matt Sturgeon
none Details | Review
XCF of new bannrbmp (116.57 KB, application/octet-stream)
2011-02-05 01:00 UTC, Matt Sturgeon
  Details
XCF of new dlgbmp (619.43 KB, application/octet-stream)
2011-02-05 01:00 UTC, Matt Sturgeon
  Details
Mockup of licence page w/ new bannrbmp (116.08 KB, image/png)
2011-02-05 18:05 UTC, Matt Sturgeon
  Details
XCF of new bannrbmp (154.84 KB, image/x-xcf)
2011-02-05 19:17 UTC, Matt Sturgeon
  Details
Patch 0005(Much brighter bannrbmp): Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format. (146.46 KB, patch)
2011-02-05 23:19 UTC, Matt Sturgeon
none Details | Review
[mockup]Setup-wizard(MSI) w/ new bannrbmp and dlgbmp (453.91 KB, image/png)
2011-02-06 03:42 UTC, Matt Sturgeon
  Details
Patch v6(set refs in installer.wixproj to new files also.): Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format. (147.74 KB, patch)
2011-02-06 17:01 UTC, Matt Sturgeon
committed Details | Review

Description Matt Sturgeon 2011-02-01 00:36:14 UTC
There are images in the windows-build bitmaps directory, that appear to be designed for an MSI installer, which are MonoDevelop branded.

They are:
banshee/build/windows/Bitmaps/bannrbmp.bmp
banshee/build/windows/Bitmaps/dlgbmp.bmp

I would be happy to design Banshee-branded bitmaps following the basic structure of those already, but I am not 100% sure what they are for, and I cannot test to find out or test my designs since I cannot seem to successfully build ()but that's another issue)..
Comment 1 Gabriel Burt 2011-02-01 03:00:35 UTC
Created attachment 179766 [details]
screenshot showing how they're used
Comment 2 Matt Sturgeon 2011-02-01 03:08:28 UTC
ohh, so it is the setup wizerd/installer... I'll design some Banshee branded ones ASAP.
Comment 3 Matt Sturgeon 2011-02-01 07:46:30 UTC
Created attachment 179770 [details] [review]
Patch to add banshee branded MSI bitmaps

Ok, I've developed some Banshee themed replacements. I feel they are fairly high quality. I included Banshee colours, and added texture by watermarking the famous mono version of the icon also..
Comment 4 Matt Sturgeon 2011-02-01 07:49:47 UTC
Created attachment 179771 [details]
XCF of new dlgbmp.bmp
Comment 5 Matt Sturgeon 2011-02-01 07:51:11 UTC
Created attachment 179772 [details]
XCF of new bannrbmp.bmp
Comment 6 Gabriel Burt 2011-02-02 00:58:35 UTC
Thanks Matt, these look pretty good!  The one that shows up on the second setup screen is too dark though, it makes the text hard to read.

Also, can you change them to JPG files?  I just tested this, it works (need to change InstallerDefinition.wxs too).  700 KB just for these BMPs is silly.
Comment 7 Alexander Kojevnikov 2011-02-02 01:34:18 UTC
I don't think WiX supports anything other than bmp. It's still worth converting the bitmaps to use an indexed colour palette, if they don't use it already.
Comment 8 Matt Sturgeon 2011-02-02 10:07:09 UTC
I'll work on making the banner bitmap lighter. The formatting of the images is, imo, a separate bug.

Also, where should the XCF files be archived so that they can be made use of in the future?
Comment 9 Matt Sturgeon 2011-02-02 13:12:45 UTC
Created attachment 179877 [details] [review]
New: 2nd Patch to add banshee branded MSI bitmaps

The updated patch has a lighter bannrbmp.bmp which I hope will make text more readable.
Comment 10 Matt Sturgeon 2011-02-02 13:13:53 UTC
Created attachment 179878 [details]
XCF of new bannrbmp.bmp

Updated XCF - the XCF used for the current bannrbmp.bmp
Comment 11 Matt Sturgeon 2011-02-02 13:19:54 UTC
Note: I forgot to comment that the bitmaps are now RGB 24bit as opposed to RGBA 32bit. This reduces the size to:
bannerbmp.bmp 83.8KB (the new one in 32bit is 111KB)
dlgbmp.bmp 450KB (my 32bit is 600KB)

I compared RGB 16bit, RGB 24bit and RGBA 32bit (no RGB option for 32bit) BMPs and 16 bit lost way to much quatity, whereas 24bit looked almost identical to 32bit, but saving much disk size.


If someone can make WiX (whatever that is) support more compressed or faster accessed formats, I'm happy to export to that format.
Comment 12 Gabriel Burt 2011-02-03 18:45:44 UTC
Like I said in comment #6, I actually tested that it supports JPGs -- it does.  Can you attach a screenshot of the installer showing these in use, too?  Thanks!
Comment 13 Matt Sturgeon 2011-02-03 18:54:05 UTC
well I can't build: so no screenshots: you can always try it in a cloned branch
Comment 14 Gabriel Burt 2011-02-03 18:56:35 UTC
Try the updated build instructions: http://banshee.fm/download/development/#windows
Comment 15 Matt Sturgeon 2011-02-03 19:22:57 UTC
Created attachment 180015 [details] [review]
New: 3nd(now JPEG format) Patch to add banshee branded MSI bitmaps

Ok, I updated to patch to be JPEG formatted now. And yes, I have used the latest instructions, I was in the email thread that discussed them. TBH I've always struggled with building from source - I always got some error, whatever project I tried (maybe I'm just unlucky with hardware/software). I attempt a regular pull, snapshot, build though.

Anyway long story short: no screenshots coming from me ;P
Comment 16 Gabriel Burt 2011-02-03 19:39:11 UTC
Comment on attachment 180015 [details] [review]
New: 3nd(now JPEG format) Patch to add banshee branded MSI bitmaps

I just updated the instructions about 30 minutes ago -- are you sure you've used the latest?

The banner one is still too dark, and I just noticed, on the "select where to install to" page, the text intersects with the logo.
Comment 17 Gabriel Burt 2011-02-03 19:40:21 UTC
This is not a major bug.  Please read https://bugzilla.gnome.org/page.cgi?id=fields.html#importance which says Major="Major loss of functionality - menu item broken, data output extremely incorrect, or otherwise difficult/useless to use. "
Comment 18 Matt Sturgeon 2011-02-03 19:41:30 UTC
Can I have a to scale screenshot or various pages please?

Ofcourse, one solution could be to reword the text?
Comment 19 Matt Sturgeon 2011-02-03 19:44:21 UTC
ok, I just refreshed and the instructions ARE different: I will attempt them but still request the screenshots.
Comment 20 Matt Sturgeon 2011-02-03 19:53:59 UTC
BTW, you need to clarify that checkout-banshee.bat needs to be run from within msysgit.
Comment 21 Gabriel Burt 2011-02-03 20:33:54 UTC
Hey Matt, it'd be great if you joined us in #banshee on irc.gnome.org to walk through the latest installation instructions.  Or if that's not doable, the mailing list or a new bug would probably be best.
Comment 22 Matt Sturgeon 2011-02-03 23:12:25 UTC
Created attachment 180028 [details]
Candidate bannrbmp.jpg

How is this bannrbmp?

I increased the brightness of the background and reduced the scale of the logo.

Will try to build the installer at some point soon.
Comment 23 Matt Sturgeon 2011-02-05 00:56:24 UTC
Created attachment 180146 [details] [review]
Patch 0004: Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format.

Ok this patch should fix this bug.
- Added Banshee branded jpegs to the installer
- Various fixes to bannrbmp.jpg regarding text-overlap and visibility
- Re-messaged commit to include "Windows:"
Comment 24 Matt Sturgeon 2011-02-05 01:00:08 UTC
Created attachment 180148 [details]
XCF of new bannrbmp
Comment 25 Matt Sturgeon 2011-02-05 01:00:44 UTC
Created attachment 180149 [details]
XCF of new dlgbmp
Comment 26 Gabriel Burt 2011-02-05 17:28:16 UTC
The banner is still just too dark.  Can you make it just the Banshee icon right-aligned on a white background?
Comment 27 Matt Sturgeon 2011-02-05 17:34:17 UTC
It's no darker than the MonoDevelop one...
Ok, I'll look at making it even lighter
Comment 28 Matt Sturgeon 2011-02-05 18:05:06 UTC
Created attachment 180184 [details]
Mockup of licence page w/ new bannrbmp

Ok, I've updated bannrbmp to make it much brighter - I knocked up this mockup (based on a screenshot of how it was before) to show you roughly how it should look.
Comment 29 Matt Sturgeon 2011-02-05 19:17:51 UTC
Created attachment 180189 [details]
XCF of new bannrbmp
Comment 30 Matt Sturgeon 2011-02-05 23:19:54 UTC
Created attachment 180194 [details] [review]
Patch 0005(Much brighter bannrbmp): Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format.

Updated patch: Much brighter bannrbmp; attempting to make it light enough for commit.

See also Attachment #180184 [details] "Mockup of licence page w/ new bannrbmp".
See also Attachment #180189 [details] "XCF of new bannrbmp"
See also Attachment #180149 [details] "XCF of new dlgbmp"
Comment 31 Matt Sturgeon 2011-02-06 03:42:40 UTC
Created attachment 180206 [details]
[mockup]Setup-wizard(MSI) w/ new bannrbmp and dlgbmp

This screenshots of all the setup pages, that I added the latest bannrbmp and dlgbmp to in GIMP. It should show you how the MSI will look when the patch is applied.
(I can't build the installer - build-installer.js gives me an error, with or without the patch).
Comment 32 Matt Sturgeon 2011-02-06 17:01:23 UTC
Created attachment 180237 [details] [review]
Patch v6(set refs in installer.wixproj to new files also.): Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format.

Ok, I updated the filenames in Installer.wixproj and changed the icon to Bitmaps\banshee.ico

I also managed to build the MSI with my patch in Bug #641565 and test that it works, and is readable, and looks good.
Comment 33 Matt Sturgeon 2011-02-06 20:48:30 UTC
I think that's this finished, I'd just like clarification that I got the Installer.wixproj and InstallerDefinition.wxs changes right.
Comment 34 Gabriel Burt 2011-02-07 00:01:51 UTC
Comment on attachment 180237 [details] [review]
Patch v6(set refs in installer.wixproj to new files also.): Windows: Added Banshee windows setup installer bitmaps - converted to JPEG format.

Committed, thanks Matt!

Check out the commit msg to see how I prefer it.