After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641565 - Build: build-installer.js: compile-target 'candel.exe' parameter 'platform' not set
Build: build-installer.js: compile-target 'candel.exe' parameter 'platform' n...
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Windows
: Normal critical
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-04 22:52 UTC by Matt Sturgeon
Modified: 2011-02-07 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of error (only on screen for .3 of a second!) (30.25 KB, image/png)
2011-02-04 22:52 UTC, Matt Sturgeon 		  Details
Remove "Condition" from <Platform> to fix bgo#641565 (903 bytes, patch)
2011-02-06 17:04 UTC, Matt Sturgeon 		committed Details | Review

Description Matt Sturgeon 2011-02-04 22:52:39 UTC 
Created attachment 180132 [details]
Screenshot of error (only on screen for .3 of a second!)

build-installer.js fails build with error CNDL0264 "The parameter 'platform' is missing orhas an invalid value MCD. Possible values are x86, x64, or ia64."

This is in Installer.wixproj (default target) (1) -> (Compile target) -> candle.exe.

Suggested fix: set 'platform' to x86, if we are only supporting this architecture (for now) on Windows.
Comment 1 Matt Sturgeon 2011-02-06 08:40:13 UTC 
Does anyone know where the wix target parameters for candle.exe would be set?
Comment 2 Matt Sturgeon 2011-02-06 16:14:14 UTC 
I have pinpointed this to Installer.wixproj line3 "<Platform Condition=" '$(Platform)' == '' ">x86</Platform>" when removing the Condition it builds successfully.

Do we need the Condition for anything specific?
Comment 3 Matt Sturgeon 2011-02-06 17:04:55 UTC 
Created attachment 180238 [details] [review]
Remove "Condition" from <Platform> to fix bgo#641565
Comment 4 Gabriel Burt 2011-02-07 00:11:17 UTC 
Comment on attachment 180238 [details] [review]
Remove "Condition" from <Platform> to fix bgo#641565

Committed, thanks Matt