GNOME Bugzilla – Bug 640200
Chat tab typing icon permanently stays in the typing state in case a typing contact suddenly leaves the room.
Last modified: 2011-01-24 12:22:06 UTC
If a contact who is typing in a chat-room or PMUC suddenly leaves the room, the typing icon in the chat tab doesn't turn back to a group icon unless the user who left joins in again and starts composing and then stops composing. If any other user starts composing a , the following debug log is obtained: http://pastebin.com/yjJpeJdk which shows "was composing" as true although it's false. The chat-tab status icon should update when a contact leaves the chat too.
Created attachment 178959 [details] [review] Update a chat tab when a composing member leaves a MUC Proposed patch
PS: one needs telepathy-gabble version 0.11.5.1 for testing this bug and patch
(In reply to comment #1) > Created an attachment (id=178959) [details] [review] > Update a chat tab when a composing member leaves a MUC > > Proposed patch pushed in public branch: http://gitorious.org/glassrose-gnome/empathy/commits/update-chat-tab-when-a-contact-leaves-640200
Review of attachment 178959 [details] [review]: You are doing it the wrong way around. Components in libempathy(-gtk) shouldn't access to the ones in src/. ::: libempathy-gtk/empathy-chat.c @@ +2226,3 @@ + + for (l = priv->compositors; l != NULL; l = l->next) { + if (l->data == contact) This look wrong, shouldn't you have {} ?
On IRC, we decided to stop working on this bug and instead remove the typing icon from being displayed on tabs entirely (as requested in bug: https://bugzilla.gnome.org/show_bug.cgi?id=609420) since a typing-icon close to the composing members is more informational and has been implemented in the master. Closing this bug as "wontfix".