After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639284 - port to gtk3
port to gtk3
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on: 630684 632307 632603 639572
Blocks:
 
 
Reported: 2011-01-12 05:17 UTC by William Jon McCann
Modified: 2011-03-04 02:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop GtkObject usage (2.19 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Port to GTK3 (59.43 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Sync notification area stuff with shell (41.75 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Remove user switch applet (80.11 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Use a GNOME 3 style for greeter panel (26.02 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Disable resize grip on panel (983 bytes, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Remove notification area (90.99 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Add status menus (20.22 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
Don't use a null icon (1.07 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review
The --gconf-prefix has been removed from g-s-d (1.78 KB, patch)
2011-01-15 02:09 UTC, William Jon McCann
none Details | Review

Description William Jon McCann 2011-01-12 05:17:54 UTC
Will post some patches for a gtk3 port.
Comment 1 William Jon McCann 2011-01-15 02:09:01 UTC
Created attachment 178370 [details] [review]
Drop GtkObject usage
Comment 2 William Jon McCann 2011-01-15 02:09:08 UTC
Created attachment 178371 [details] [review]
Port to GTK3
Comment 3 William Jon McCann 2011-01-15 02:09:15 UTC
Created attachment 178372 [details] [review]
Sync notification area stuff with shell

And port to gtk3.
Comment 4 William Jon McCann 2011-01-15 02:09:18 UTC
Created attachment 178373 [details] [review]
Remove user switch applet

The GNOME 3 shell has one and this one will move to the fallback panel.
Comment 5 William Jon McCann 2011-01-15 02:09:21 UTC
Created attachment 178374 [details] [review]
Use a GNOME 3 style for greeter panel

In the new design the panel only affects settings for the current session,
in this case the greeter session, and not the resulting login session.
Comment 6 William Jon McCann 2011-01-15 02:09:23 UTC
Created attachment 178375 [details] [review]
Disable resize grip on panel
Comment 7 William Jon McCann 2011-01-15 02:09:26 UTC
Created attachment 178376 [details] [review]
Remove notification area
Comment 8 William Jon McCann 2011-01-15 02:09:29 UTC
Created attachment 178377 [details] [review]
Add status menus
Comment 9 William Jon McCann 2011-01-15 02:09:32 UTC
Created attachment 178378 [details] [review]
Don't use a null icon
Comment 10 William Jon McCann 2011-01-15 02:09:35 UTC
Created attachment 178379 [details] [review]
The --gconf-prefix has been removed from g-s-d
Comment 11 William Jon McCann 2011-01-15 02:38:13 UTC
Also pushed here: http://git.gnome.org/browse/gdm/log/?h=gnome3
Comment 12 Matthias Clasen 2011-01-15 03:51:54 UTC
Review of attachment 178374 [details] [review]:

::: gui/simple-greeter/gdm-greeter-panel.c
@@ +906,3 @@
         widget_class->show = gdm_greeter_panel_real_show;
         widget_class->hide = gdm_greeter_panel_real_hide;
+        widget_class->style_set = gdm_greeter_panel_real_style_set;

I think part of your problem with colors is that the style-set signal has been replaced by style-updated
Comment 13 Ray Strode [halfline] 2011-03-04 02:26:02 UTC
this is all done now i think.