After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632307 - Need to disable resize grip on gdm panel when building against gtk+ 3.0
Need to disable resize grip on gdm panel when building against gtk+ 3.0
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks: 639284
 
 
Reported: 2010-10-16 18:46 UTC by Cody Russell
Modified: 2011-01-21 20:21 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Disables the resize grip (448 bytes, patch)
2010-10-16 18:46 UTC, Cody Russell
reviewed Details | Review

Description Cody Russell 2010-10-16 18:46:38 UTC
Created attachment 172502 [details] [review]
Disables the resize grip

In gtk+ 3.0 the resize grips are on GtkWindow instead of GtkStatusbar, and we need to disable them in a couple places.  gdm seems to be one of them.
Comment 1 Ray Strode [halfline] 2010-10-25 20:20:32 UTC
any reason gtk doesn't call gdk_window_get_decorations under the hood and omit the resize grip if the window lacks GDK_DECOR_RESIZEH ?

Then this would work without the above patch, I think.
Comment 2 Ray Strode [halfline] 2010-10-25 20:23:51 UTC
Review of attachment 172502 [details] [review]:

::: gui/simple-greeter/gdm-greeter-panel.c
@@ +888,3 @@
 {
         panel->priv = GDM_GREETER_PANEL_GET_PRIVATE (panel);
+        gtk_window_set_has_resize_grip (GTK_WINDOW (panel), FALSE);

If this is required, we probably want it in setup_panel with everything else instead of on its own here.
Comment 3 Matthias Clasen 2011-01-21 20:21:38 UTC
panel on master has no resize grip