After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638252 - language-support-vala: use the new markers to show error tooltips
language-support-vala: use the new markers to show error tooltips
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: language-support-vala
unspecified
Other All
: Normal normal
: ---
Assigned To: Abderrahim Kitouni
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-29 08:25 UTC by Abderrahim Kitouni
Modified: 2011-01-06 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libanjuta: add some gobject-introspection annotations (5.53 KB, patch)
2010-12-29 08:25 UTC, Abderrahim Kitouni 		committed Details | Review
language-support-vala: update the .vapi for 3.0 (133.62 KB, patch)
2010-12-29 08:26 UTC, Abderrahim Kitouni 		committed Details | Review
language-support-vala: use the new markers to show error tooltips (4.81 KB, patch)
2010-12-29 08:27 UTC, Abderrahim Kitouni 		committed Details | Review
language-support-vala: simplify logic a bit by using new vala API (5.91 KB, patch)
2010-12-29 08:27 UTC, Abderrahim Kitouni 		committed Details | Review
language-support-vala: fix misuse of CodeContext.add_package (1.19 KB, patch)
2011-01-04 13:26 UTC, Abderrahim Kitouni 		accepted-commit_now Details | Review

Description Abderrahim Kitouni 2010-12-29 08:25:20 UTC 
I'm also attaching patches to update the vapi
Comment 1 Abderrahim Kitouni 2010-12-29 08:25:38 UTC 
Created attachment 177176 [details] [review]
libanjuta: add some gobject-introspection annotations

There is much work to do on this front, I've only looked at APIs used
by the vala support plugin or that prevent correct generation of vapi
Comment 2 Abderrahim Kitouni 2010-12-29 08:26:28 UTC 
Created attachment 177178 [details] [review]
language-support-vala: update the .vapi for 3.0
Comment 3 Abderrahim Kitouni 2010-12-29 08:27:00 UTC 
Created attachment 177179 [details] [review]
language-support-vala: use the new markers to show error tooltips
Comment 4 Abderrahim Kitouni 2010-12-29 08:27:31 UTC 
Created attachment 177180 [details] [review]
language-support-vala: simplify logic a bit by using new vala API

also fix misuse of context.add_package
Comment 5 Johannes Schmid 2010-12-29 10:08:44 UTC 
Review of attachment 177176 [details] [review]:

Thanks!

That of course needs some more work for the other APIs but we will fix that over time.

::: libanjuta/anjuta-status.c
@@ -614,2 +617,2 @@
 void
 anjuta_status (AnjutaStatus *status, const gchar *mesg, gint timeout)

This one should be anjuta_status_set() or anjuta_status_set_status() to be properly supported, right? We should change that at some point.
Comment 6 Johannes Schmid 2010-12-29 10:10:59 UTC 
Review of attachment 177178 [details] [review]:

Looks good! Thanks!
Comment 7 Johannes Schmid 2010-12-29 10:58:36 UTC 
When I apply all these patches anjuta crashes:

+ Trace 225314

  • #0 vala_collection_get_size
    at collection.c line 216
  • #1 vala_code_context_get
    at valacodecontext.c line 544
  • #2 vala_report_error
    at valareport.c line 401
  • #3 vala_code_context_add_external_package
    at valacodecontext.c line 733
  • #4 vala_plugin_real_activate
    at plugin.c line 393
  • #5 anjuta_plugin_activate
    at anjuta-plugin.c line 537
  • #6 plugin_set_update
    at anjuta-plugin-manager.c line 758
  • #7 anjuta_plugin_manager_get_plugin_by_id
    at anjuta-plugin-manager.c line 1540
  • #8 load_new_support_plugins
    at plugin.c line 1090 

Any clues?
Comment 8 Johannes Schmid 2010-12-29 14:00:37 UTC 
Review of attachment 177179 [details] [review]:

Thanks, nice addition!
Comment 9 Johannes Schmid 2010-12-29 14:01:07 UTC 
Review of attachment 177180 [details] [review]:

Thanks, less code is always good!
Comment 10 Johannes Schmid 2010-12-29 14:01:47 UTC 
Sorry, the crash was due to bug 638228, see there.

These patches are fine! Thanks!
Comment 11 Abderrahim Kitouni 2011-01-04 13:21:49 UTC 
it seems 177180 wasn't completely committed (the context.get_[external_]package part isn't in master), I'm attaching a fix
Comment 12 Abderrahim Kitouni 2011-01-04 13:26:35 UTC 
Created attachment 177479 [details] [review]
language-support-vala: fix misuse of CodeContext.add_package

(this was supposed to be in 46aeb2136566, but somehow it isn't)
Comment 13 Johannes Schmid 2011-01-06 17:32:00 UTC 
Review of attachment 177479 [details] [review]:

Sorry, seems I missed.

VALAFLAGS should be queryable somehow but that's for later.
Comment 14 Abderrahim Kitouni 2011-01-06 19:01:10 UTC 
(In reply to comment #13)
> Review of attachment 177479 [details] [review]:
> 
> Sorry, seems I missed.
> 
> VALAFLAGS should be queryable somehow but that's for later.

Yes, that's what I'm going to work on next ;-)