After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638228 - language-support-vala: interrupt parsing if user switches to another file
language-support-vala: interrupt parsing if user switches to another file
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: language-support-vala
unspecified
Other All
: Normal normal
: ---
Assigned To: Abderrahim Kitouni
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-28 23:31 UTC by Abderrahim Kitouni
Modified: 2010-12-29 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
language-support-vala: interrupt parsing if user switches to another file (2.69 KB, patch)
2010-12-28 23:32 UTC, Abderrahim Kitouni 		needs-work Details | Review
language-support-vala: fix a crash when bindings aren't found (1.12 KB, patch)
2010-12-29 20:00 UTC, Abderrahim Kitouni 		committed Details | Review

Description Abderrahim Kitouni 2010-12-28 23:31:18 UTC 
This should make deactivating the plugin faster if it was activated and 
just then deactivated (like it happens on startup)

(this patch is independent of others that will follow in another bug)
Comment 1 Abderrahim Kitouni 2010-12-28 23:32:03 UTC 
Created attachment 177168 [details] [review]
language-support-vala: interrupt parsing if user switches to another file
Comment 2 Johannes Schmid 2010-12-29 10:05:41 UTC 
Review of attachment 177168 [details] [review]:

Looks good - thanks!
Comment 3 Johannes Schmid 2010-12-29 13:59:44 UTC 
Review of attachment 177168 [details] [review]:

OK, I could track this down to this patch. Anjuta crashes when you open a vala file or if you switch to a vala files (assuming it was loaded with the session):

+ Trace 225317

  • #0 vala_collection_get_size
    at collection.c line 216
  • #1 vala_code_context_get
    at valacodecontext.c line 544
  • #2 vala_report_error
    at valareport.c line 401
  • #3 vala_code_context_add_external_package
    at valacodecontext.c line 733
  • #4 vala_plugin_real_activate
    at plugin.c line 393
  • #5 anjuta_plugin_activate
    at anjuta-plugin.c line 537
  • #6 plugin_set_update
    at anjuta-plugin-manager.c line 758
  • #7 anjuta_plugin_manager_get_plugin_by_id
    at anjuta-plugin-manager.c line 1540
  • #8 load_new_support_plugins
    at plugin.c line 1090
  • #9 update_language_plugin
    at plugin.c line 1184
  • #10 on_document_changed
    at plugin.c line 1233 

Otherwise the patch seems to squash out a couple of critical warnings which is really good but doesn't help as long as it is crashing.
Comment 4 Abderrahim Kitouni 2010-12-29 20:00:08 UTC 
Created attachment 177208 [details] [review]
language-support-vala: fix a crash when bindings aren't found

The bug was there before and is just triggered by the combination of 
the above patch and patch 177180 (which btw I don't see when I pull).

I had fixed this in a later commit as I didn't understand where it was 
introduced. Anyway, this patch should fix it.

(just curious: what are you testing that requires the vapi for gdl?)
Comment 5 Johannes Schmid 2010-12-29 21:45:25 UTC 
Review of attachment 177208 [details] [review]:

OK, that works for me - thanks!