GNOME Bugzilla – Bug 635637
Allow to seek past fill-level when download buffering
Last modified: 2014-06-04 13:44:23 UTC
Untested patch attached.
Created attachment 175127 [details] [review] Allow to seek past fill-level when download buffering
Review of attachment 175127 [details] [review]: I haven't tested it either, but our GStreamer dependency will need bumping to 0.10.31 due to gst_query_parse_nth_buffering_range().
Created attachment 175319 [details] [review] Allow to seek past fill-level when download buffering
Comment on attachment 175127 [details] [review] Allow to seek past fill-level when download buffering Added the GStreamer req, but it's not good enough, and it completely fail to seek when seeking past the fill level, when it's supposed to be pushing the request to the source. We'd need to pause again, seek, and wait for the fill to be good enough to play.
Not going to happen for 3.0, but might for a bug fix release, or 3.2.
*** Bug 614129 has been marked as a duplicate of this bug. ***
*** Bug 674135 has been marked as a duplicate of this bug. ***
Created attachment 218958 [details] [review] Allow to seek past fill-level when download buffering
Comment on attachment 218958 [details] [review] Allow to seek past fill-level when download buffering Updated for master
Created attachment 219143 [details] [review] Allow to seek past fill-level when download buffering
Comment on attachment 219143 [details] [review] Allow to seek past fill-level when download buffering needs-work as we still have a FIXME in the code for wtay. We also need to make sure that seeking forward then seeking back changes the fill level to the maximum value in the current range.
Created attachment 219241 [details] [review] backend: Allow seeking past fill-level When download buffering
Created attachment 252932 [details] [review] backend: Allow seeking past fill-level When download buffering
Comment on attachment 252932 [details] [review] backend: Allow seeking past fill-level Updated for master, still waiting on GStreamer fixes.
Created attachment 277730 [details] [review] backend: Allow seeking past fill-level When download buffering
I've asked Wim to review the buffering code in totem, to make sure we don't regress: <hadess> wtay_, the code to review would be totem master + the patch in that bug <hadess> wtay_, the 2 functions to check, in src/backend/bacon-video-widget.c would be: bvw_handle_buffering_message and bvw_query_buffering_timeout <hadess> wtay_, i want to double check that, when download buffering, i handle "i have enough buffer to play until the end of the stream" correctly, as well as "i have downloaded the whole media, and i can save it locally" <wtay_> hadess, you want to start playing when it is estimated that no rebuffering will happen? <hadess> wtay_, yes, when it can play until the end, without buffering again, given the current download rate <wtay_> all right
Created attachment 277831 [details] [review] improved download buffering This is an additional patch to improve download buffering some more. It needs to be used with latest master of GStreamer.
Merged, with some fixes for the comments.