Bug 635151 – Expecting GdkDrawable where cairo_t is used

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 635151 - Expecting GdkDrawable where cairo_t is used


Summary:	Expecting GdkDrawable where cairo_t is used


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Do Not Use
Version:	3.0.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Vibha Yadav
QA Contact:	Evolution QA team

URL:
Whiteboard:	evolution[gtk3]

Depends on:
Blocks:	636677

Reported:	2010-11-18 08:56 UTC by Vibha Yadav
Modified:	2013-09-13 12:24 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Patch for not crashing while asking for password (752 bytes, patch) 2010-11-18 09:03 UTC, Vibha Yadav	none	Details \| Review
Patch for not crashing while asking for password (1.31 KB, patch) 2010-11-18 10:09 UTC, Vibha Yadav	committed	Details \| Review

Description Vibha Yadav 2010-11-18 08:56:53 UTC

1)I have built evolution gtk3 branch with patches provided in https://bugzilla.gnome.org/show_bug.cgi?id=633478
2)Created a new account.
3)Evolution crashed while asking for password.

+ Trace 224732

Thread 1 (Thread 0xb63a0810 (LWP 16551))

#0 gdk_cairo_create
at gdkcairo.c line 68
#1 ecb_draw
at e-canvas-background.c line 200
#2 gnome_canvas_group_draw
at gnome-canvas.c line 1517
#3 gnome_canvas_paint_rect
at gnome-canvas.c line 1781
#4 gnome_canvas_draw
at gnome-canvas.c line 2299
#5 _gtk_marshal_BOOLEAN__BOXED
#6 gtk_widget_draw_marshaller
at gtkwidget.c line 810
#7 g_type_class_meta_marshal
at gclosure.c line 877
#8 g_closure_invoke
at gclosure.c line 766
#9 signal_emit_unlocked_R
at gsignal.c line 3290
#10 g_signal_emit_valist
at gsignal.c line 2993
#11 g_signal_emit
at gsignal.c line 3040
#12 _gtk_widget_draw_internal
at gtkwidget.c line 5504
#13 gtk_widget_send_expose
at gtkwidget.c line 5744
#14 gtk_main_do_event
at gtkmain.c line 1689
#15 _gdk_window_process_updates_recurse
at gdkwindow.c line 3976
#16 _gdk_window_process_updates_recurse
at gdkwindow.c line 3949
#17 _gdk_window_process_updates_recurse
at gdkwindow.c line 3949
#18 _gdk_windowing_window_process_updates_recurse
at gdkwindow-x11.c line 5491
#19 gdk_window_process_updates_internal
at gdkwindow.c line 4134
#20 gdk_window_process_all_updates
at gdkwindow.c line 4242
#21 gdk_window_update_idle
at gdkwindow.c line 3865
#22 gdk_threads_dispatch
at gdk.c line 502
#23 g_idle_dispatch
at gmain.c line 4347
#24 g_main_dispatch
at gmain.c line 2267
#25 g_main_context_dispatch
at gmain.c line 2824
#26 g_main_context_iterate
at gmain.c line 2902
#27 g_main_loop_run
at gmain.c line 3110
#28 gtk_main
at gtkmain.c line 1321
#29 main
at main.c line 694

Comment 1 Vibha Yadav 2010-11-18 09:03:27 UTC

Created attachment 174755 [details] [review]
Patch for not crashing while asking for password

Evolution was crashing because we were passing cairo_t variable and taking GdkDrawable as an argument of ecb_draw. and then again converting it to cairo_t.

Comment 2 Akhil Laddha 2010-11-18 09:38:39 UTC

Crash bug is critical in severity always :-)

Comment 3 Vibha Yadav 2010-11-18 10:09:48 UTC

Created attachment 174758 [details] [review]
Patch for not crashing while asking for password

Evolution was crashing because we were passing cairo_t variable and taking
GdkDrawable as an argument of ecb_draw. and then again converting it to
cairo_t.

Missed to remove cairo_destroy calls

Comment 4 Chenthill P 2010-11-29 15:01:46 UTC

Review of attachment 174758 [details] [review]:

Please ensure that cairo context is destroyed. As this patch depends on
http://bugzilla-attachments.gnome.org/attachment.cgi?id=175026 , this can be
pushed after the earlier one is committed.

Comment 5 Milan Crha 2011-01-21 14:38:03 UTC

chen, it will be really great if you name bug # instead of attachment link. I hope you know why. It's bug #633478 (Andre helped me to figure out what the bug is from your link).

The chunk from e-table-header-utils.c is wrong, the first part is fine. Couple similar places are missing to be fixed too. I'll update the patch.

Comment 6 Milan Crha 2011-01-21 14:47:05 UTC

Errr, it's really committed already. My fault. I'm sorry.

Comment 7 Milan Crha 2011-01-21 15:04:57 UTC

OK, I do not know why the bug is still opened, the patch is in, the code in question is changed heavily, and I didn't get any crash on password prompt. All that together => I'm closing this bug report.