GNOME Bugzilla – Bug 633478
some random gtk fixes
Last modified: 2013-09-13 01:10:43 UTC
Created attachment 173494 [details] [review] patch Here are some misc. fixes for size_request going away (will happen soon), dialog separators being gone, and some other stuff. I took out the e-mail-attachement size-request handler, that should just be fixed in gtkhtml... This is both incomplete and untested, since I can't get close to a full build of evo against current gtk. But it may still be useful.
I've pushed a "gtk3" branch where these patches can be applied until 3.0 is released. http://git.gnome.org/browse/evolution/log/?h=gtk3
Created attachment 174648 [details] [review] Avoid Using Deprecated GTK_SELECTION_EXTENDED Using GTK_SELECTION_MULTIPLE. As Deprecated, GTK_SELECTION_EXTENDED behaves identical to GTK_SELECTION_MULTIPLE.
Created attachment 174649 [details] [review] Patch for Adapting deprecated expose-event signal for GtkWidget for gtk-3.0 Changes Using draw signal instead of expose-event signal
Created attachment 174650 [details] [review] Patch for Avoiding Deprecated Flag GTK_DIALOG_NO_SEPERATOR Using NULL instead of it
Created attachment 174651 [details] [review] Patch for Using GTK_COMBO_BOX instead of deprecated GTK_COMBO_BOX_ENTRY
Created attachment 174751 [details] [review] Patch for Using cairo_surface_t instead of deprecated GdkPixmap apis Instead of using deprecated GdkPixmap api's Use cairo_surface_t and pixbuf api's for getting images
Created attachment 174752 [details] [review] Avoid Using Deprecated GdkColormap
Created attachment 175026 [details] [review] Patch for Using cairo_surface_t instead of deprecated GdkPixmap apis Instead of using deprecated GdkPixmap api's Use cairo_surface_t and pixbuf api's for getting images.
Created attachment 175447 [details] [review] Patch for build failure as size_request is deprecated Using get_preferred_width/height instead of deprecated size_request
Review of attachment 174648 [details] [review]: looks good. please commit
Review of attachment 174649 [details] [review]: Please fix if the pointed ones are memory leaks and commit the patch. ::: calendar/gui/e-meeting-time-sel.c @@ +908,3 @@ mts = g_object_get_data (G_OBJECT (darea), "data"); + window_cr = gdk_cairo_create (window); shouldn this be free'ed ? @@ +1246,3 @@ window = gtk_widget_get_window (GTK_WIDGET (mts)); + cr = gdk_cairo_create(window); shouldn this be free'ed ?
Review of attachment 174650 [details] [review]: looks good. please commit.
Review of attachment 174651 [details] [review]: ::: addressbook/gui/contact-editor/e-contact-editor-fullname.c @@ +234,2 @@ widget = e_builder_get_widget (builder, "comboentry-title"); + gtk_combo_box_set_entry_text_column (GTK_COMBO_BOX (widget), 0); is the widget a GtkComboBox or GtkComboBoxEntry ? Wont this require changes in .ui files as well ? This question holds good to changes in other files as well.
(In reply to comment #13) > Review of attachment 174651 [details] [review]: > > ::: addressbook/gui/contact-editor/e-contact-editor-fullname.c > @@ +234,2 @@ > widget = e_builder_get_widget (builder, "comboentry-title"); > + gtk_combo_box_set_entry_text_column (GTK_COMBO_BOX (widget), 0); > > is the widget a GtkComboBox or GtkComboBoxEntry ? Wont this require changes in > .ui files as well ? > > This question holds good to changes in other files as well. Hmm, those changes lie in another bug 635171. Please commit both the patches together. It would be great if you attach these kind of patches in a single bug and prolly a single patch would be enough ;)
Review of attachment 175026 [details] [review]: Please do not use C++ style comments. I hope there the alternate for GdkColorMap is GDkVisual. Please replace it with the alternative rather than just commenting the pieces.
The above comment holds good for GdkPixmap patch as well. Please also test the patch from Matthias and commit the changes, tia.
Comment on attachment 174651 [details] [review] Patch for Using GTK_COMBO_BOX instead of deprecated GTK_COMBO_BOX_ENTRY committed with https://bugzilla.gnome.org/attachment.cgi?id=174763
Committed patches to gtk3 branch.
Created attachment 176116 [details] [review] Avoid Using Deprecated GdkColormap Reworked. Removed C++ commenting style.
Created attachment 176118 [details] [review] Patch for Using cairo_surface_t instead of deprecated GdkPixmap apis Reworked and removed c++ commenting style
Created attachment 176119 [details] [review] Patch for build failure as size_request is deprecated This patch contains extra changes other than mathias patch. Using get_preferred_width/height instead of deprecated size_request
Created attachment 176120 [details] [review] Patch for evolution Some random changes: + depth parameter is removed from gdk_window_get_geometry api + adding dependency for libunique as evolution is not able to link properly with unique.h + porting changes from https://bugzilla.gnome.org/show_bug.cgi?id=633774
Created attachment 176124 [details] [review] Patch for evolution Adapting changes in draw api call for gtk+-3.0. As GdkDrawable is now deprecated http://git.gnome.org/browse/gtk+/commit/?id=218eea43785809ce43e894ed1bd94e18757f4efa
*** Bug 636900 has been marked as a duplicate of this bug. ***
Created attachment 176320 [details] [review] Patch for Using GtkScrollable API instead of deprecated GtkLayout API's Using gtk_scrollable_get_vadjustment instead of gtk_layout_get_vadjustment and gtk_scrollable_get_hadjustment instead of gtk_layout_get_hadjustment
All GTK3 branches built fine for me today so I'm closing this.