After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634332 - XRandR system indicator
XRandR system indicator
Status: RESOLVED WONTFIX
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 630913 634253
Blocks:
 
 
Reported: 2010-11-08 16:13 UTC by Giovanni Campagna
Modified: 2010-11-15 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Status area: add display indicator (7.76 KB, patch)
2010-11-08 16:13 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2010-11-08 16:13:04 UTC
Although not listed in the wiki, code says that display is a standard indicator, and as such is treated the gnome-settings-daemon status icon.
So we should replace the status icon (actually dead in g-s-d master) with a native Shell indicator.
Comment 1 Giovanni Campagna 2010-11-08 16:13:38 UTC
Created attachment 174066 [details] [review]
Status area: add display indicator

Adds an indicator that allows you to quickly change your display
configuration (currently, only the rotation). Uses the DBus API
exposed by gnome-settings-daemon and the new introspected API in
libgnome-desktop.
Comment 2 Owen Taylor 2010-11-14 19:09:15 UTC
So, the option to display this indicator has been removed from System Settings. f you:

 - Are running an old control center and g-s-d
 - Have the option turned on

It's probably better to display it up top as a legacy status icon than nothing. So it's fine to have it in the list of "system indicators".

But I don't think we need to have a implementation of this in our code; if it can't be turned on through the UI it won't get testing and will probably break.

For reorientable devices our order of preference would be:

 A) Automatic sensors
 B) Hardware orientation keys

It's possible that certain devices would need an onscreen switch - we've known that our standard design can't handle every possible hardware device without adaptation. That case is something we can explore in the future.... but I don't think we understand the use cases well enough to land code now.

Even though I'm WONTFIX'ing, many thanks for doing the patch!
Comment 3 Giovanni Campagna 2010-11-14 19:22:46 UTC
(In reply to comment #2)
> So, the option to display this indicator has been removed from System Settings.
> f you:
> 
>  - Are running an old control center and g-s-d
>  - Have the option turned on
> 
> It's probably better to display it up top as a legacy status icon than nothing.
> So it's fine to have it in the list of "system indicators".
> 
> But I don't think we need to have a implementation of this in our code; if it
> can't be turned on through the UI it won't get testing and will probably break.

Actually note that, like all the other system indicators, this is always shown. There is no GSettings key to turn it off, like the GNOME 2 version.

> For reorientable devices our order of preference would be:
> 
>  A) Automatic sensors
>  B) Hardware orientation keys
> 
> It's possible that certain devices would need an onscreen switch - we've known
> that our standard design can't handle every possible hardware device without
> adaptation. That case is something we can explore in the future.... but I don't
> think we understand the use cases well enough to land code now.
> 
> Even though I'm WONTFIX'ing, many thanks for doing the patch!

No problem, it will be fine as an extension, for people needing it.
Comment 4 Owen Taylor 2010-11-14 19:47:11 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > So, the option to display this indicator has been removed from System Settings.
> > f you:
> > 
> >  - Are running an old control center and g-s-d
> >  - Have the option turned on
> > 
> > It's probably better to display it up top as a legacy status icon than nothing.
> > So it's fine to have it in the list of "system indicators".
> > 
> > But I don't think we need to have a implementation of this in our code; if it
> > can't be turned on through the UI it won't get testing and will probably break.
> 
> Actually note that, like all the other system indicators, this is always shown.
> There is no GSettings key to turn it off, like the GNOME 2 version.

I noted that, but I was assuming that if we were to land it we'd need to hook it up to a GSettings key and have it off by default. I certainly don't need a permanent icon to turn my laptop's screen display sideways! :-)
Comment 5 Bastien Nocera 2010-11-15 15:29:34 UTC
bug 631995 is about whether we should have such an icon at all, so work should be done first on the design of it, rather than copying the (very unuseful) status icon that was in GNOME 2.x.