After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632787 - keyboard navigation is not possible anymore
keyboard navigation is not possible anymore
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
: 639452 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-10-21 12:02 UTC by Jonh Wendell
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jonh Wendell 2010-10-21 12:02:55 UTC
Since 2.32, which came with a live search, I can't browse my contacts with the keyboard.

I can go up and down with up and down keys, but when I press Space to expand/retract a group, I got the live search in action
Comment 1 Guillaume Desmottes 2010-10-22 08:43:57 UTC
Right, we should expand/hide the group if it's selected.
Comment 2 Will Thompson 2010-11-12 12:29:51 UTC
I think hitting space should activate the currently-selected row if we're not searching. If the user starts a search by typing an alphanumeric character, hitting space should insert a space into the current search string.

(via bug 634612.)
Comment 3 Guillaume Desmottes 2010-11-17 12:48:52 UTC
I agree.
Comment 4 Jonathon Jongsma 2010-12-01 21:10:51 UTC
It's not just spacebar that's broken.  Also things like <PgDn>, <PgUp>, <Home>, and <End> should navigate / scroll the contact list, but they no longer work.
Comment 5 Will Thompson 2011-05-19 17:16:20 UTC
*** Bug 639452 has been marked as a duplicate of this bug. ***
Comment 6 Daniel Stone 2011-05-20 11:28:17 UTC
> I think hitting space should activate the currently-selected row
> if we're not searching. If the user starts a search by typing an
> alphanumeric character, hitting space should insert a space into
> the current search string.

Yes please!

Also, sorry to grief this report with semi-unrelated other bugs (I can file another if you'd like), but WRT comment #4, turns out it only works once:
 * Focus contact list by clicking on it
 * Press Page Down
 * Contact list scrolls down one page, selects an element in the next page but defocuses the list (as seen by selection having a gray rather than blue background)
 * Press Page Down again
 * Nothing happens
 * Manually focus contact list by clicking on it
 * GOTO 20
Comment 7 Guillaume Desmottes 2011-05-20 14:07:56 UTC
I fixed this in master. <PgDn> <PgUp> <Home> and <End> now work as expected.
Space either active the current cell or adds a space depending if a live search is already running.

Note that it currently only active "contacts" cell (to start a chat), expander cells are not because of bug #650614

I committed only in master for now just in cases of regressions. If we don't observe any I may backport to 3.0 if people find it useful.

For the record, the commits are:



commit d94c2c708734d6a41cd6d6ad44684a816b66cff8
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri May 20 16:02:44 2011 +0200

    live-search: fix keyboard navigation using Space (#632787)

commit 50cc20d66183eb0e4a8fd1384dea77fdf3e29cf0
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri May 20 15:38:03 2011 +0200

    live-search:fix keyboard navigation using PageUp/PageDown (#632787)

commit c105d23a6dc033e281304a0032095f13e7fef63f
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri May 20 15:32:33 2011 +0200

    live-search: fix keyboard navigation using Home/End (#632787)

commit 584931b9c50f9390ba19d8609ac9917b570d6562
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri May 20 15:26:50 2011 +0200

    factor out fire_key_navigation_sig()

commit 12c7f7de95068377ff60b23bdc5d80367d554c2b
Author: Xavier Claessens <xclaesse@gmail.com>
Date:   Fri May 20 15:18:10 2011 +0200

    Always forward to the view keynav events, since we get them only if they are useless to the entry anyway

commit ee227ec984e99ab5f1046c68b891413ba1b89507
Author: Xavier Claessens <xclaesse@gmail.com>
Date:   Fri May 20 15:17:33 2011 +0200

    LiveSearch: we don't want to emit keynav signal on left/right since those are useful to the entry



This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.