After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632440 - No menu item for opening tomboy help
No menu item for opening tomboy help
Status: RESOLVED NOTGNOME
Product: tomboy
Classification: Applications
Component: General
unspecified
Other Mac OS
: Normal normal
: 1.6.0
Assigned To: Stefan Schweizer
Tomboy Maintainers
gnome[moved-to-github]
Depends on:
Blocks:
 
 
Reported: 2010-10-18 09:57 UTC by Stefan Schweizer
Modified: 2017-07-31 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add menu item for opening online help (1.18 KB, patch)
2010-10-18 09:57 UTC, Stefan Schweizer
committed Details | Review

Description Stefan Schweizer 2010-10-18 09:57:57 UTC
Created attachment 172595 [details] [review]
Add menu item for opening online help

Currently it is not possible to open the online help from the mac help menu.

I am attaching a patch to fix this. It also opens the specific version of the online help. We could do this in the WindowsApplication and GnomeApplication classes too.
Comment 1 Sandy Armstrong 2010-10-18 14:41:38 UTC
Review of attachment 172595 [details] [review]:

yes
Comment 2 Stefan Schweizer 2010-10-18 14:46:41 UTC
Does yes only mean that the patch is ok or that we also should change the DisplayHelp method in the application classes for the other platforms to open a specific help version?
Comment 3 Sandy Armstrong 2010-10-18 15:03:43 UTC
The version change would only work in WindowsApplication.  If you want to make the change there, too, go for it.

This can all make today's release.
Comment 4 Stefan Schweizer 2010-10-18 16:04:09 UTC
Review of attachment 172595 [details] [review]:

I just pushed the changes of the patch and the additional modifications for the WindowsApplication.
Comment 5 Stefan Schweizer 2010-10-18 18:19:34 UTC
Just noticed that after applying the changes the tools menu is now gone.
Comment 6 Sandy Armstrong 2010-10-18 18:34:22 UTC
Hmm, unfortunate.  I'm not sure how to edit the Help menu properly.  I wonder if checking out MonoDevelop's code would help us:

http://github.com/mono/monodevelop/tree/master/main/src/addins/MacPlatform/
Comment 7 Sandy Armstrong 2010-10-18 22:00:56 UTC
Commit reverted in git.

I tried copying the Tools/Sync menu/menuitem from SyncManager.Initialize, but the Help menuitem didn't show up when I did that.  So, not sure what's up.
Comment 8 Stefan Schweizer 2010-10-18 22:23:18 UTC
I think you reverted the wrong commit. The problem is the one with the addition to the menu xml in commit 3d8fb16. Sorry for the confusion and my only half-working patches.
Comment 9 Sandy Armstrong 2010-10-18 22:49:19 UTC
Sigh, why didn't I notice this comment *before* I tagged and uploaded a tarball and a Mac binary? :-P
Comment 10 Stefan Schweizer 2010-10-20 09:38:04 UTC
I still have not found the right way to do that. I do not understand why it is necessary at all because UIManagerLayout.xml already has a HelpMenu defined with an item for ShowHelpAction.
Comment 11 André Klapper 2017-07-31 12:46:58 UTC
The Tomboy team has moved from GNOME Bugzilla to GitHub for bug reports and feature requests: 
      https://github.com/tomboy-notes/tomboy/issues/
Closing this report as NOTGNOME as part of Bugzilla Housekeeping (bug 781054) to keep tasks in one place. Please feel free to transfer this task to GitHub if this task is still valid in a recent Tomboy version. 
We are sorry for the inconvenience.