GNOME Bugzilla – Bug 630892
Show explanation why pictures source might be empty
Last modified: 2013-06-04 13:35:59 UTC
+++ This bug was initially created as a clone of Bug #630417 +++ While trying the new background panel, I noticed some small issues: - my pictures folder only contains subdirectories. if I select 'Pictures', the sidebar stays empty. Probably best to not offer 'Pictures' at all, if there's no pictures to choose from Or show a "no pictures" label in the treeview instead.
I have encountered the same issue today. My ~/Pictures directory is virtually empty and I have my favourite wallpaper pictures in a separate wallpapers/ subdirectory. It is sad to not be able to select them from the background panel. :(
(In reply to comment #1) > I have encountered the same issue today. My ~/Pictures directory is virtually > empty and I have my favourite wallpaper pictures in a separate wallpapers/ > subdirectory. It is sad to not be able to select them from the background > panel. :( You can add and remove "pictures" by hand now. Showing a button or a label in the list view would be nice though.
*** Bug 691813 has been marked as a duplicate of this bug. ***
I've begun working on this, my intention is follow an observed design pattern and crib from Documents - explicitly I intend to have a dimmed UI with the emblem-photos-symbolic icon and some text: "No Pictures Found You can add images to your Pictures folder and they will show up here." with the word Pictures being a hyperlink which calls gtk_open_uri (g_get_user_special_dir (G_USER_DIRECTORY_PICTURES))); I'd like to add some explanatory text to explain that only images in the top-level Pictures directory will be shown but am struggling with forming a sentence which doesn't sound like it's written by an engineer: "images in sub-directories of the Pictures folder will not be shown" Any suggestions here?
Created attachment 245278 [details] [review] First attempt at implementation of this feature Here's a first attempt at this based on the EmptyResultsBox in gnome-documents. My main concerns are that I'm not sure if the translatable string is formed in an appropriate way and the explanation I've added for what's wrong doesn't cover any of the details (we won't show screenshots, gifs or images in subdirectories).
Created attachment 245597 [details] [review] First attempt at implementation of this feature Embarrassingly the first uploaded version of this patch didn't even compile, not sure how I managed that but here's the correct patch.
Review of attachment 245597 [details] [review]: We may need UI review from the design team, but the patch looks good otherwise.
Created attachment 245723 [details] Screenshot
Pretty close. Should look like this https://raw.github.com/gnome-design-team/gnome-mockups/master/documents/documents-empty.png
Created attachment 245816 [details] layout guidance Thanks for the patch, Joshua! I agree with Jon - this isn't far off. There are just a few tweaks to make to padding and alignment. The attached image might help with this; feel free to ask questions if you have them.
Created attachment 245972 [details] Updated screenshot Thanks Jon and Allan for the feedback, in the attached screenshot I've changed the alignment of the labels such that they are both left-aligned and tweaked the spacing.
Created attachment 245973 [details] [review] Updated patch with spacing and alignment tweaks
So, images in subdirectories of ~/Pictures will still not show up? Images that should get selected as wallpapers have to be lose files in ~/Pictures?