After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630417 - Only hide colours/style if preset in background metadata
Only hide colours/style if preset in background metadata
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 641458 (view as bug list)
Depends on: 637363
Blocks:
 
 
Reported: 2010-09-23 14:33 UTC by Matthias Clasen
Modified: 2011-02-14 09:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: Come up with 'Wallpapers' selected and displayed (1.61 KB, patch)
2010-09-23 18:26 UTC, Kalev Lember 		committed Details | Review
background: Don't disable edit buttons for system wallpapers (1.12 KB, patch)
2010-09-23 18:26 UTC, Kalev Lember 		needs-work Details | Review

Description Matthias Clasen 2010-09-23 14:33:23 UTC 
While trying the new background panel, I noticed some small issues:

- when it comes up, the sidebar is empty (nothing selected, and nothing displayed). It should come up with 'Wallpapers' selected and displayed

- we used to have some information in tooltips on the wallpapers. If the tooltips are not considered cool anymore, we should perhaps some more of that information in the 'name' area at the bottom. We've had requests from the Fedora art guys to show author and license information, e.g.

- we also seem to have lost the slideshow stepping feature again 

- as soon as I change the current selection, the color and zoom buttons in the lower right

- my pictures folder only contains subdirectories. if I select 'Pictures', the sidebar stays empty. Probably best to not offer 'Pictures' at all, if there's no pictures to choose from

- the colors should probably be editable somehow. dnd from/to the color button ?
Comment 1 Kalev Lember 2010-09-23 18:25:11 UTC 
I hope I'm not stepping on someone's toes with picking low hanging fruit here.
Comment 2 Kalev Lember 2010-09-23 18:26:11 UTC 
Created attachment 170955 [details] [review]
background: Come up with 'Wallpapers' selected and displayed
Comment 3 Kalev Lember 2010-09-23 18:26:40 UTC 
Created attachment 170956 [details] [review]
background: Don't disable edit buttons for system wallpapers
Comment 4 Bastien Nocera 2010-09-29 11:31:01 UTC 
Comment on attachment 170955 [details] [review]
background: Come up with 'Wallpapers' selected and displayed

Attachment 170955 [details] pushed as c55ec39 - background: Come up with 'Wallpapers' selected and displayed
Comment 5 Bastien Nocera 2010-09-29 11:45:53 UTC 
Review of attachment 170956 [details] [review]:

This is wrong, or rather, incomplete.

Some of the backgrounds will have their style (stretched, zoom, etc.) and/or backrgound colours set in the XML file.

Instead, each item in a non-read-only source should have the ability to say whether the colour settings, or the style should be settable. You'll probably have to create your own XML file for the background though, as I don't see any of the ones shipped on my distribution using those features.
Comment 6 Bastien Nocera 2010-09-29 11:51:35 UTC 
Split the bugs, and renamed this one.

Kalev, let us know if you intend on working on any of those.
Comment 7 Bastien Nocera 2011-02-11 19:57:56 UTC 
This is now fixed with the backend rework. Note that this only works when *setting* new wallpapers, as we don't have any information on what was the old setup.
Comment 8 Bastien Nocera 2011-02-12 15:03:37 UTC 
*** Bug 641458 has been marked as a duplicate of this bug. ***