After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630539 - xulrunner 1.9.3+ patches
xulrunner 1.9.3+ patches
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 624745 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-24 18:04 UTC by Colin Walters
Modified: 2010-09-30 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support xulrunner 1.9.3+ (6.36 KB, patch)
2010-09-24 18:04 UTC, Colin Walters 		committed Details | Review
telepathy: Use string.replace in a way compatible with newer Spidermonkey (1.22 KB, patch)
2010-09-24 18:04 UTC, Colin Walters 		none Details | Review
telepathy: Use string.replace in a way compatible with newer Spidermonkey (1.16 KB, patch)
2010-09-24 18:08 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2010-09-24 18:04:07 UTC 
Basically straightforward stuff, though I didn't check for other string.replace uses.
Comment 1 Colin Walters 2010-09-24 18:04:11 UTC 
Created attachment 171048 [details] [review]
Support xulrunner 1.9.3+

Add small wrappers around JS_AddValueRoot.
Add JS_BeginRequest in our custom code.
Comment 2 Colin Walters 2010-09-24 18:04:14 UTC 
Created attachment 171049 [details] [review]
telepathy: Use string.replace in a way compatible with newer Spidermonkey

The semantics of the first argument changed from literal -> regexp
if the 'g' option was specified.  To remove ambiguity, stop using
the spidermonkey extension and create a standard RegExp object.
Comment 3 Colin Walters 2010-09-24 18:08:36 UTC 
Created attachment 171050 [details] [review]
telepathy: Use string.replace in a way compatible with newer Spidermonkey

Fix the other user I saw
Comment 4 Owen Taylor 2010-09-25 00:15:26 UTC 
Review of attachment 171050 [details] [review]:

Good
Comment 5 Owen Taylor 2010-09-25 00:29:03 UTC 
Review of attachment 171048 [details] [review]:

Looks good, a style comment about the configure.ac change

::: configure.ac
@@ +117,3 @@
+if test "x$have_js_newglobalobject" = xtrue; then
+  AC_DEFINE(HAVE_JS_NEWGLOBALOBJECT, 1,
+    [Define if -lmozjs has NewGlobalObject])

Can't you just add JS_NewGlobalObject into the AC_CHECK_FUNCS where sn_startup_sequence_get_application_id is checked? (The comment above needs a littel adjustment if you do that)
Comment 6 Owen Taylor 2010-09-25 16:52:10 UTC 
*** Bug 624745 has been marked as a duplicate of this bug. ***
Comment 7 Owen Taylor 2010-09-30 16:43:52 UTC 
Attachment 171048 [details] pushed as 11db188 - Support xulrunner 1.9.3+
Attachment 171050 [details] pushed as e22fbda - telepathy: Use string.replace in a way compatible with newer Spidermonkey