After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624745 - support build with xulrunner 2.0
support build with xulrunner 2.0
Status: RESOLVED DUPLICATE of bug 630539
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Colin Walters
gnome-shell-maint
Depends on: 622896
Blocks:
 
 
Reported: 2010-07-19 14:41 UTC by Maxim Ermilov
Modified: 2010-09-25 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
support build with xulrunner 2.0 (1.66 KB, patch)
2010-07-19 14:43 UTC, Maxim Ermilov 		none Details | Review

Description Maxim Ermilov 2010-07-19 14:41:05 UTC 
patch follow
Comment 1 Maxim Ermilov 2010-07-19 14:43:19 UTC 
Created attachment 166163 [details] [review]
support build with xulrunner 2.0
Comment 2 Owen Taylor 2010-07-29 12:45:04 UTC 
Review of attachment 166163 [details] [review]:

This will need to be conditional. (See handling of sn_startup_sequence_get_application_id in configure.ac... you probably can just add JS_RemoveValueRoot to that same AC_CHECK_FUNCS, please keep the functions alphabetical.)
Comment 3 Maxim Ermilov 2010-07-29 14:12:05 UTC 
(In reply to comment #2)
> 
> This will need to be conditional. 
No. Patch for Gjs Handle this. It add HAVE_JS_ADDROOT to compile flags. It define new functions for old xullruner.
Comment 4 Owen Taylor 2010-07-30 07:27:03 UTC 
You mean, that GJS actually will define the JS_* symbols and export them???
Comment 5 Owen Taylor 2010-09-25 16:52:10 UTC 
Dup'ing on Colin's patch

*** This bug has been marked as a duplicate of bug 630539 ***