After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630424 - The Cancel button can't be translated (patch)
The Cancel button can't be translated (patch)
Status: RESOLVED OBSOLETE
Product: gdm
Classification: Core
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 639617 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-23 15:07 UTC by Ville-Pekka Vainio
Modified: 2011-02-28 02:12 UTC
See Also:
GNOME target: 2.32.x
GNOME version: ---

Attachments
Fix translations of the Cancel button (1.32 KB, patch)
2010-09-23 15:07 UTC, Ville-Pekka Vainio 		accepted-commit_after_freeze Details | Review

Description Ville-Pekka Vainio 2010-09-23 15:07:25 UTC 
Created attachment 170923 [details] [review]
Fix translations of the Cancel button

The Cancel button in GDM can't be translated. The attached patch uses a stock GTK Cancel button instead of a custom one. This way the translations will be taken from GTK, the string freeze won't be broken and it won't require any changes from the translators. The Cancel button was broken by git commit 706a532d, this patch essentially reverts the .ui file part of that commit.

There is a Fedora bug for this issue as well: 
https://bugzilla.redhat.com/show_bug.cgi?id=634548
Comment 1 Yaron Shahrabani 2010-10-04 05:57:58 UTC 
Also reported in Ubuntu:
https://bugs.edge.launchpad.net/ubuntu/+source/gdm/+bug/654387
Comment 2 Takao Fujiwara 2010-10-05 03:21:09 UTC 
bug 630424 and bug 631235 .
FYI: One concern is "Log In" and "Password" have no accelerator key but GtkStock gtk-cancel has the accelerator "_C".

Regarding to bug 631280, pam module has the translation out of gdm.
Comment 3 André Klapper 2011-01-17 21:33:37 UTC 
*** Bug 639617 has been marked as a duplicate of this bug. ***
Comment 4 André Klapper 2011-01-22 14:14:25 UTC 
Ping - can this get a commit now in either gtk3 or master or both, please?
Ray?
Comment 5 Matthias Clasen 2011-02-28 02:12:30 UTC 
The string is marked as translatable in current gdm. 
Switching back to using the stock gtk string might make sense, in the light of auto-mnemonics, but the translation issue is solved.