GNOME Bugzilla – Bug 630276
Hitting redial doesn't clear error messages
Last modified: 2011-08-29 10:12:28 UTC
Created attachment 170768 [details] o hai Hello, I tried to make a video call today. It didn't work, because Cheese was using my webcam. So I got a beautiful error bar. I quit Cheese, and hit Redial. It still didn't work (which was unexpected and saddening), and I got a second beautiful error bar. So I mashed Redial a few more times... see the attachment. ಠ_ಠ I think hitting Redial should clear any previous error bar. I also think we could use a more useful error message for this situation than: *Can't establish video stream* There was a failure in the call engine v Technical Details /Could not link source/ (Also, the capitalization of the ‘D’ in ‘Details’ shocks me.)
Created attachment 170819 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/redial-630276 src/empathy-call-window.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
(In reply to comment #0) > I also think we could use a more useful error message for this situation than: > > *Can't establish video stream* > There was a failure in the call engine > v Technical Details > /Could not link source/ Probably. I opened bug #630325 > (Also, the capitalization of the ‘D’ in ‘Details’ shocks me.) Not sure what's right here. http://library.gnome.org/devel/hig-book/nightly/design-text-labels.html.en#layout-capitalization doesn't mention labels in GtkExpander.
(In reply to comment #2) > Not sure what's right here. > http://library.gnome.org/devel/hig-book/nightly/design-text-labels.html.en#layout-capitalization > doesn't mention labels in GtkExpander. I guess it should probably follow ‘Group box or frame labels’, which means the status quo is fine. Your patch looks like it should probably work.
Comment on attachment 170819 [details] [review] http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/redial-630276 Thanks. I'll merge after the 2.32.0 release.
Merged. Will be fixed in 2.32.1.