After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627916 - Can't build with GTK3 any more
Can't build with GTK3 any more
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
: 628092 628172 (view as bug list)
Depends on: 624570
Blocks: 628043
 
 
Reported: 2010-08-25 08:10 UTC by Guillaume Desmottes
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check for gcr-1 when building against GTK+ 3 (2.17 KB, patch)
2010-08-28 07:55 UTC, Frederic Peters 		accepted-commit_now Details | Review
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gtk3-627916 (782 bytes, patch)
2010-09-01 08:24 UTC, Guillaume Desmottes 		none Details | Review

Description Guillaume Desmottes 2010-08-25 08:10:27 UTC 
We added a dep on libgcr (gnome-keyring) which is great and all but unfortunatelly break GTK3 build :(

This lib linked on GTK2 and has not been ported to GTK3 yet (bug #624570).
Once a GTK3 flavour of the lib is released we should tweak Empathy's configure to pick the right version depending on the GTK version used.
Comment 1 Baptiste Mille-Mathias 2010-08-27 07:11:44 UTC 
*** Bug 628092 has been marked as a duplicate of this bug. ***
Comment 2 Frederic Peters 2010-08-28 07:20:10 UTC 
*** Bug 628172 has been marked as a duplicate of this bug. ***
Comment 3 Frederic Peters 2010-08-28 07:55:21 UTC 
Created attachment 168933 [details] [review]
Check for gcr-1 when building against GTK+ 3
Comment 4 Guillaume Desmottes 2010-08-30 08:21:33 UTC 
Review of attachment 168933 [details] [review]:

Yes please!
Comment 5 Guillaume Desmottes 2010-08-30 15:00:31 UTC 
I needed the patch for the release so I merged it myself.
For some reason git am didn't like it so I had to re-commit it :\

 $ git am /tmp/gtk.patch
Patch format detection failed.
Comment 6 Guillaume Desmottes 2010-09-01 08:24:17 UTC 
Created attachment 169216 [details] [review]
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/gtk3-627916

 configure.ac |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
Comment 7 Guillaume Desmottes 2010-09-01 10:00:35 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.